bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

[Chris Corbyn]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Hi All,

See http://stackoverflow.com/questions/8321589/emacs-find-and-replace-regex-in-multiple-files-find-name-dired-q-doesnt-sa/8329696#8329696 for the original question.  I've been told to officially report the bug.

Basically I'm trying to find & replace across all files in my project; which I'm doing by starting find-name-dired, then selecting all the files in my project, hitting "Q" for Query & Replace, and following the interactive process.

It is doing the search and replace in exactly the way I'd expect, but she  I try to save the 27 buffers it leaves open (using save-some-buffers) it says there are no changes to be saved.  Trying to save a single buffer does the same thing, yet I can see the changes clear as day.  Editing the buffer and saving it again does work, but this is not practical over 27 of them; obviously there's a bug here with the find & replace not marking the buffers as modified.

I also tried using IBuffer to save all the buffers, which reported to have saved them, but actually hadn't written anything to disk.  I assume that IBuffer's reporting of what it saved is actually just telling me how many buffers were selected when I asked it to save the, but is not checking to make sure they really did save.

Can somebody please confirm that this is a bug and/or provide a suitable workaround? :)  I'd just do this on the command line if I didn't need to do it interactively, due to some ambiguities.

Cheers,

Chris


[-- Attachment #2: Type: text/html, Size: 1974 bytes --]

bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

[Stefan Monnier]

> It is doing the search and replace in exactly the way I'd expect, but she
> I try to save the 27 buffers it leaves open (using save-some-buffers) it
> says there are no changes to be saved.  Trying to save a single buffer does

I can't reproduce this problem here.
I tried:

   [ starting from some elisp package directory (tuareg in this case) ]
   % emacs23 -Q
   M-x find-name-dired RET
   RET
   *.el RET
   t
   Q
   with RET when RET
   !!!!!!.... ad nauseam
   M-x save-some-buffers RET
   yyyyyy.....

The last line is because it asked me whether to save each buffer.


        Stefan

bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

[Chris Corbyn]

I compiled Emacs from source recently (a couple of months ago).  The version given is "GNU Emacs 23.3.1".

Hopefully this narrows it down.  What exact version are you using, Stefan?


On 01/12/2011, at 8:42 AM, Stefan Monnier wrote:

>> It is doing the search and replace in exactly the way I'd expect, but she
>> I try to save the 27 buffers it leaves open (using save-some-buffers) it
>> says there are no changes to be saved.  Trying to save a single buffer does
> 
> I can't reproduce this problem here.
> I tried:
> 
>   [ starting from some elisp package directory (tuareg in this case) ]
>   % emacs23 -Q
>   M-x find-name-dired RET
>   RET
>   *.el RET
>   t
>   Q
>   with RET when RET
>   !!!!!!.... ad nauseam
>   M-x save-some-buffers RET
>   yyyyyy.....
> 
> The last line is because it asked me whether to save each buffer.
> 
> 
>        Stefan

bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

[Chris Corbyn]

Switched to emacs HEAD and its working there, thanks.  Expected everything to explode under HEAD with regards to the extensions I have installed, but fortunately it seems to work.

Not sure how to close this request, but consider it closed :)


On 01/12/2011, at 8:42 AM, Stefan Monnier wrote:

>> It is doing the search and replace in exactly the way I'd expect, but she
>> I try to save the 27 buffers it leaves open (using save-some-buffers) it
>> says there are no changes to be saved.  Trying to save a single buffer does
> 
> I can't reproduce this problem here.
> I tried:
> 
>   [ starting from some elisp package directory (tuareg in this case) ]
>   % emacs23 -Q
>   M-x find-name-dired RET
>   RET
>   *.el RET
>   t
>   Q
>   with RET when RET
>   !!!!!!.... ad nauseam
>   M-x save-some-buffers RET
>   yyyyyy.....
> 
> The last line is because it asked me whether to save each buffer.
> 
> 
>        Stefan

bug#10174: find-named-dired followed by Query and Replace leaves emacs in a bad state

[Stefan Monnier]

> I compiled Emacs from source recently (a couple of months ago).  The version
> given is "GNU Emacs 23.3.1".
> Hopefully this narrows it down.  What exact version are you using, Stefan?

I'm using the `emacs23' package from Debian testing, which is a lightly
patched Emacs-23.3 (the ".1" is not actually part of the version
information: it's a build counter).

I'm happy to hear it's fixed for you on the trunk, but I'm still puzzled.
Can you reproduce it starting from "emacs -Q" with Emacs-23.3?


        Stefan