unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
@ 2017-09-27  1:49 YAMAMOTO Mitsuharu
  2017-09-27  8:13 ` martin rudalics
  0 siblings, 1 reply; 9+ messages in thread
From: YAMAMOTO Mitsuharu @ 2017-09-27  1:49 UTC (permalink / raw)
  To: 28611

Steps to reproduce:

  1. $ emacs -Q &
  2. Enlarge the frame a bit by mouse.
  3. Type (make-frame `((parent-frame . ,(selected-frame)))) C-j
  4. Click the newly created child frame.
  5. Type (iconify-frame) C-j

Result:

  The child frame becomes unresponsive.
  The parent frame can take input, but the cursor is still hollow.

Maybe an attempt to iconify a child frame should cause an error.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

In GNU Emacs 26.0.60 (build 1, x86_64-apple-darwin16.7.0, X toolkit, Xaw3d scroll bars)
 of 2017-09-27 built on YAMAMOTO-no-iMac-5K.local
Repository revision: a3f647c5c810e8be5321bf99cb21d565590a7cf8
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --without-ns --with-jpeg=no --with-gif=no --with-tiff=no
 --with-gnutls=no PKG_CONFIG=/opt/local/bin/pkg-config
 PKG_CONFIG_PATH=/usr/lib/pkgconfig:/opt/X11/lib/pkgconfig:/usr/local/lib/pkgconfig
 PKG_CONFIG_LIBDIR='

Configured features:
XAW3D XPM PNG NOTIFY ACL LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11

Important settings:
  value of $LANG: ja_JP.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util japan-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue dynamic-setting
font-render-setting x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 97322 7132)
 (symbols 48 20135 1)
 (miscs 40 54 86)
 (strings 32 28850 1995)
 (string-bytes 1 740494)
 (vectors 16 14679)
 (vector-slots 8 566966 11070)
 (floats 8 51 65)
 (intervals 56 250 13)
 (buffers 992 12))






^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-09-27  1:49 bug#28611: 26.0.60; iconifying a child frame seems to be problematic YAMAMOTO Mitsuharu
@ 2017-09-27  8:13 ` martin rudalics
  2017-09-27  9:21   ` YAMAMOTO Mitsuharu
  0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2017-09-27  8:13 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu, 28611

 > Steps to reproduce:
 >
 >    1. $ emacs -Q &
 >    2. Enlarge the frame a bit by mouse.
 >    3. Type (make-frame `((parent-frame . ,(selected-frame)))) C-j
 >    4. Click the newly created child frame.
 >    5. Type (iconify-frame) C-j
 >
 > Result:
 >
 >    The child frame becomes unresponsive.
 >    The parent frame can take input, but the cursor is still hollow.
 >
 > Maybe an attempt to iconify a child frame should cause an error.

We warn about this in the Elisp manual:

    * The semantics of maximizing and iconifying child frames is highly
      window-system dependent.  As a rule, applications should never
      invoke these operations for child frames.

I'm not sure whether we should do more about this given the fact that
these operations may and should work well on other window systems.

BTW: Does ‘make-frame-visible’ invoked for the child frame make it
responsive again?

martin






^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-09-27  8:13 ` martin rudalics
@ 2017-09-27  9:21   ` YAMAMOTO Mitsuharu
  2017-09-29  8:32     ` martin rudalics
  0 siblings, 1 reply; 9+ messages in thread
From: YAMAMOTO Mitsuharu @ 2017-09-27  9:21 UTC (permalink / raw)
  To: martin rudalics; +Cc: 28611

>>>>> On Wed, 27 Sep 2017 10:13:13 +0200, martin rudalics <rudalics@gmx.at> said:

>> Steps to reproduce:
>> 
>> 1. $ emacs -Q &
>> 2. Enlarge the frame a bit by mouse.
>> 3. Type (make-frame `((parent-frame . ,(selected-frame)))) C-j
>> 4. Click the newly created child frame.
>> 5. Type (iconify-frame) C-j
>> 
>> Result:
>> 
>> The child frame becomes unresponsive.
>> The parent frame can take input, but the cursor is still hollow.
>> 
>> Maybe an attempt to iconify a child frame should cause an error.

> We warn about this in the Elisp manual:

>     * The semantics of maximizing and iconifying child frames is highly
>       window-system dependent.  As a rule, applications should never
>       invoke these operations for child frames.

I've overlooked that.  Thanks for the info.

> I'm not sure whether we should do more about this given the fact that
> these operations may and should work well on other window systems.

I think at least C-z should iconify the top-level frame so users may
not confuse.

> BTW: Does ‘make-frame-visible’ invoked for the child frame make it
> responsive again?

Yes.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-09-27  9:21   ` YAMAMOTO Mitsuharu
@ 2017-09-29  8:32     ` martin rudalics
  2017-10-01  8:24       ` martin rudalics
  0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2017-09-29  8:32 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu; +Cc: 28611

 > I think at least C-z should iconify the top-level frame so users may
 > not confuse.

I think you're right.  Maybe I'll also add some customizations to allow
‘iconify-frame’ to alternatively act on the parent, the top level frame
(the default probably), make the frame invisible, or do nothing at all.
And provide something similar for maximizations.

Thanks, martin






^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-09-29  8:32     ` martin rudalics
@ 2017-10-01  8:24       ` martin rudalics
  2017-10-02  0:55         ` YAMAMOTO Mitsuharu
  2017-10-02 17:27         ` Glenn Morris
  0 siblings, 2 replies; 9+ messages in thread
From: martin rudalics @ 2017-10-01  8:24 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu; +Cc: 28611

 >  > I think at least C-z should iconify the top-level frame so users may
 >  > not confuse.
 >
 > I think you're right.  Maybe I'll also add some customizations to allow
 > ‘iconify-frame’ to alternatively act on the parent, the top level frame
 > (the default probably), make the frame invisible, or do nothing at all.

Done now - please have a look.

 > And provide something similar for maximizations.

Deferred until someone reports bad behavior in this area.

Thanks for the suggestion, martin






^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-10-01  8:24       ` martin rudalics
@ 2017-10-02  0:55         ` YAMAMOTO Mitsuharu
  2017-10-02 17:27         ` Glenn Morris
  1 sibling, 0 replies; 9+ messages in thread
From: YAMAMOTO Mitsuharu @ 2017-10-02  0:55 UTC (permalink / raw)
  To: martin rudalics; +Cc: 28611-done

>>>>> On Sun, 01 Oct 2017 10:24:18 +0200, martin rudalics <rudalics@gmx.at> said:

>> > I think at least C-z should iconify the top-level frame so users
>> > may not confuse.
>> 
>> I think you're right.  Maybe I'll also add some customizations to
>> allow ‘iconify-frame’ to alternatively act on the parent, the top
>> level frame (the default probably), make the frame invisible, or do
>> nothing at all.

> Done now - please have a look.

It looks nice.  Thanks.  Closing the bug.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-10-01  8:24       ` martin rudalics
  2017-10-02  0:55         ` YAMAMOTO Mitsuharu
@ 2017-10-02 17:27         ` Glenn Morris
  2017-10-02 18:37           ` Eli Zaretskii
  1 sibling, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2017-10-02 17:27 UTC (permalink / raw)
  To: martin rudalics; +Cc: 28611


Hi,

b03b4f6d7 causes without-x builds to fail:

frame.c:2545:25: error: 'struct frame' has no member named 'parent_frame'
   Lisp_Object parent = f->parent_frame;

Ref eg https://hydra.nixos.org/build/62198700





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-10-02 17:27         ` Glenn Morris
@ 2017-10-02 18:37           ` Eli Zaretskii
  2017-10-03  9:15             ` martin rudalics
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2017-10-02 18:37 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 28611-done

> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 02 Oct 2017 13:27:52 -0400
> Cc: 28611@debbugs.gnu.org
> 
> b03b4f6d7 causes without-x builds to fail:
> 
> frame.c:2545:25: error: 'struct frame' has no member named 'parent_frame'
>    Lisp_Object parent = f->parent_frame;

Thanks, fixed.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#28611: 26.0.60; iconifying a child frame seems to be problematic
  2017-10-02 18:37           ` Eli Zaretskii
@ 2017-10-03  9:15             ` martin rudalics
  0 siblings, 0 replies; 9+ messages in thread
From: martin rudalics @ 2017-10-03  9:15 UTC (permalink / raw)
  To: Eli Zaretskii, Glenn Morris; +Cc: 28611-done

 >> b03b4f6d7 causes without-x builds to fail:
 >>
 >> frame.c:2545:25: error: 'struct frame' has no member named 'parent_frame'
 >>     Lisp_Object parent = f->parent_frame;
 >
 > Thanks, fixed.

Many thanks to Glenn for the report and to you for the fix.

martin





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-10-03  9:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-27  1:49 bug#28611: 26.0.60; iconifying a child frame seems to be problematic YAMAMOTO Mitsuharu
2017-09-27  8:13 ` martin rudalics
2017-09-27  9:21   ` YAMAMOTO Mitsuharu
2017-09-29  8:32     ` martin rudalics
2017-10-01  8:24       ` martin rudalics
2017-10-02  0:55         ` YAMAMOTO Mitsuharu
2017-10-02 17:27         ` Glenn Morris
2017-10-02 18:37           ` Eli Zaretskii
2017-10-03  9:15             ` martin rudalics

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).