* bug#25179: 26.0.50; Dired doesn't preserve window height
@ 2016-12-12 5:14 Liu Hui
2016-12-12 8:51 ` Tino Calancha
2017-04-15 14:49 ` martin rudalics
0 siblings, 2 replies; 7+ messages in thread
From: Liu Hui @ 2016-12-12 5:14 UTC (permalink / raw)
To: 25179
1. Emacs -Q
2. C-x 2
3. M-x dired
4. press 'm' to mark two or more files
5. press 'D'
=> the window below becomes larger
6. answer 'no'
=> the window height is not restored
The problem is not found with dired on Emacs 24.5.
In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
of 2016-12-10 built on lgw01-57
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: Ubuntu 16.04.1 LTS
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#25179: 26.0.50; Dired doesn't preserve window height
2016-12-12 5:14 bug#25179: 26.0.50; Dired doesn't preserve window height Liu Hui
@ 2016-12-12 8:51 ` Tino Calancha
2016-12-12 10:00 ` martin rudalics
2017-04-15 14:49 ` martin rudalics
2017-04-15 14:49 ` martin rudalics
1 sibling, 2 replies; 7+ messages in thread
From: Tino Calancha @ 2016-12-12 8:51 UTC (permalink / raw)
To: Liu Hui; +Cc: 25179, tino.calancha
Liu Hui <liuhui1610@gmail.com> writes:
> 1. Emacs -Q
> 2. C-x 2
> 3. M-x dired
> 4. press 'm' to mark two or more files
> 5. press 'D'
> => the window below becomes larger
> 6. answer 'no'
> => the window height is not restored
>
> The problem is not found with dired on Emacs 24.5.
Thank you.
For deleting 2-3 files Emacs24 and Emacs25 differs; for deleting
many files they looks pretty similar:
emacs -Q
C-x 2
;; Visit a directory with several hundred of files.
M-: (dired (expand-file-name "lisp" source-directory))
RET
t D no RET
;; In both releases the window displaying *scratch* becames very small.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#25179: 26.0.50; Dired doesn't preserve window height
2016-12-12 8:51 ` Tino Calancha
@ 2016-12-12 10:00 ` martin rudalics
2017-04-15 14:49 ` martin rudalics
1 sibling, 0 replies; 7+ messages in thread
From: martin rudalics @ 2016-12-12 10:00 UTC (permalink / raw)
To: Tino Calancha, Liu Hui; +Cc: 25179
>> 1. Emacs -Q
>> 2. C-x 2
>> 3. M-x dired
>> 4. press 'm' to mark two or more files
>> 5. press 'D'
>> => the window below becomes larger
>> 6. answer 'no'
>> => the window height is not restored
>>
>> The problem is not found with dired on Emacs 24.5.
> Thank you.
> For deleting 2-3 files Emacs24 and Emacs25 differs; for deleting
> many files they looks pretty similar:
>
> emacs -Q
> C-x 2
> ;; Visit a directory with several hundred of files.
> M-: (dired (expand-file-name "lisp" source-directory))
> RET
> t D no RET
> ;; In both releases the window displaying *scratch* becames very small.
This is bug#25055. I yet have to understand why the behavior changed
in the transition from 24.5 to 25.
The problem is that when fitting a window to its buffer steals space
from more than one other window, that space should be returned to those
windows when the window is eventually deleted. Returning space to more
than one window requires binding ‘window-combination-resize’ to t around
the action deleting the window. Apparently trivial, I have not yet
found a way to do that reliably.
martin
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#25179: 26.0.50; Dired doesn't preserve window height
2016-12-12 8:51 ` Tino Calancha
2016-12-12 10:00 ` martin rudalics
@ 2017-04-15 14:49 ` martin rudalics
2017-04-16 3:34 ` Tino Calancha
1 sibling, 1 reply; 7+ messages in thread
From: martin rudalics @ 2017-04-15 14:49 UTC (permalink / raw)
To: Tino Calancha, Liu Hui; +Cc: 25179
> emacs -Q
> C-x 2
> ;; Visit a directory with several hundred of files.
> M-: (dired (expand-file-name "lisp" source-directory))
> RET
> t D no RET
> ;; In both releases the window displaying *scratch* becames very small.
This should not happen any more after my last commit. Please check.
Thanks, martin
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#25179: 26.0.50; Dired doesn't preserve window height
2017-04-15 14:49 ` martin rudalics
@ 2017-04-16 3:34 ` Tino Calancha
2017-04-16 7:16 ` martin rudalics
0 siblings, 1 reply; 7+ messages in thread
From: Tino Calancha @ 2017-04-16 3:34 UTC (permalink / raw)
To: martin rudalics; +Cc: Liu Hui, 25179, Tino Calancha
On Sat, 15 Apr 2017, martin rudalics wrote:
>> emacs -Q
>> C-x 2
>> ;; Visit a directory with several hundred of files.
>> M-: (dired (expand-file-name "lisp" source-directory))
>> RET
>> t D no RET
>> ;; In both releases the window displaying *scratch* becames very small.
>
> This should not happen any more after my last commit. Please check.
Checked it. It's OK now. Thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#25179: 26.0.50; Dired doesn't preserve window height
2016-12-12 5:14 bug#25179: 26.0.50; Dired doesn't preserve window height Liu Hui
2016-12-12 8:51 ` Tino Calancha
@ 2017-04-15 14:49 ` martin rudalics
1 sibling, 0 replies; 7+ messages in thread
From: martin rudalics @ 2017-04-15 14:49 UTC (permalink / raw)
To: Liu Hui, 25179-done
> 1. Emacs -Q
> 2. C-x 2
> 3. M-x dired
> 4. press 'm' to mark two or more files
> 5. press 'D'
> => the window below becomes larger
> 6. answer 'no'
> => the window height is not restored
>
> The problem is not found with dired on Emacs 24.5.
Should have been fixed now on master with commit
23d3eeb798c7edc27898b0dbd4c2364a6ca6247d
Please (1) recompile window.el and after that (2) minibuffer.el and
dired.el and finally (3) rebuild Emacs. Closing this bug.
Thanks, martin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-16 7:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-12 5:14 bug#25179: 26.0.50; Dired doesn't preserve window height Liu Hui
2016-12-12 8:51 ` Tino Calancha
2016-12-12 10:00 ` martin rudalics
2017-04-15 14:49 ` martin rudalics
2017-04-16 3:34 ` Tino Calancha
2017-04-16 7:16 ` martin rudalics
2017-04-15 14:49 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).