From: "Mattias Engdegård" <mattiase@acm.org>
To: Juri Linkov <juri@linkov.net>
Cc: 49624@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#49624: compilation message end-column function off-by-one bug
Date: Mon, 26 Jul 2021 21:30:53 +0200 [thread overview]
Message-ID: <55B887CA-7259-43C8-89B2-53FE25AC3F5F@acm.org> (raw)
In-Reply-To: <87h7ghku9w.fsf@mail.linkov.net>
26 juli 2021 kl. 19.06 skrev Juri Linkov <juri@linkov.net>:
> my commit 9dc3a46a444a46e00ed3287a3174d73ed9511dac
> was part of efforts to add column information to grep matches,
> I added a funcall without incrementing its result by 1
> on the assumption that the function can return
> an already inclusive result that doesn't need to offset by 1.
Thank you for the thorough investigation!
> Now your commit aa5437493b1ca539409495ecdc54cf420ea110b9
> broke the highlighting of columns in grep-regexp-alist,
> so now visiting a grep match highlights an additional character
> that is not part of the grep match.
Good spotting! That one has now been fixed.
> Maybe there are more existing functions whose backward-compatibility
> is broken now.
In preparation of my change I went through lots and lots of external packages and found exactly none using a function for END-COL. This is unsurprising since the very ability to use functions for COL and END-COL wasn't documented until 2019.
Somehow I missed grep.el, but that too makes sense -- it's inside Emacs itself that the feature was most likely to be used since it was undocumented. I have now gone through the source tree once more, and there seem to be no more problems.
prev parent reply other threads:[~2021-07-26 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 19:00 bug#49624: compilation message end-column function off-by-one bug Mattias Engdegård
2021-07-18 19:10 ` Eli Zaretskii
2021-07-18 19:13 ` Mattias Engdegård
2021-07-18 19:30 ` Eli Zaretskii
2021-07-19 10:39 ` Mattias Engdegård
[not found] ` <875yx6qtwg.fsf@mail.linkov.net>
[not found] ` <5BAAD7D4-A578-4DB5-925E-ECE02B4F4B56@acm.org>
[not found] ` <87pmvevv28.fsf@mail.linkov.net>
2021-07-23 13:24 ` Mattias Engdegård
2021-07-26 17:06 ` Juri Linkov
2021-07-26 19:30 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B887CA-7259-43C8-89B2-53FE25AC3F5F@acm.org \
--to=mattiase@acm.org \
--cc=49624@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).