From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#49624: compilation message end-column function off-by-one bug Date: Mon, 26 Jul 2021 21:30:53 +0200 Message-ID: <55B887CA-7259-43C8-89B2-53FE25AC3F5F@acm.org> References: <462A3B1B-6632-4740-907D-03B67377452E@acm.org> <83h7gr781e.fsf@gnu.org> <83czrf773k.fsf@gnu.org> <5FDA92A6-421D-4A91-A2D9-D0101B115037@acm.org> <875yx6qtwg.fsf@mail.linkov.net> <5BAAD7D4-A578-4DB5-925E-ECE02B4F4B56@acm.org> <87pmvevv28.fsf@mail.linkov.net> <71FBE546-8821-497D-83A9-A6E4CF0BBBA3@acm.org> <87h7ghku9w.fsf@mail.linkov.net> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39458"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49624@debbugs.gnu.org, Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 26 21:32:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m86Kj-000A2j-NO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jul 2021 21:32:13 +0200 Original-Received: from localhost ([::1]:59832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m86Ki-0007IS-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jul 2021 15:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m86KY-0007G9-Ed for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 15:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m86KY-0007eQ-6v for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 15:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m86KY-0006B6-0J for bug-gnu-emacs@gnu.org; Mon, 26 Jul 2021 15:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jul 2021 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49624 X-GNU-PR-Package: emacs Original-Received: via spool by 49624-submit@debbugs.gnu.org id=B49624.162732787223691 (code B ref 49624); Mon, 26 Jul 2021 19:32:01 +0000 Original-Received: (at 49624) by debbugs.gnu.org; 26 Jul 2021 19:31:12 +0000 Original-Received: from localhost ([127.0.0.1]:51543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m86Jh-00069z-AI for submit@debbugs.gnu.org; Mon, 26 Jul 2021 15:31:11 -0400 Original-Received: from mail1433c50.megamailservers.eu ([91.136.14.33]:35452 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m86Jc-00069Q-JH for 49624@debbugs.gnu.org; Mon, 26 Jul 2021 15:31:08 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627327857; bh=2p47vnly8TO9CTQnUNx9vG7V+eeQGpExzJPqXWqk4/4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=YJLObWMu/me7vcEeTgiyraEIrR6GWU3HjxdfGWWaKQHr16xXpuztenci7f53YNi0p 8rVT6yOPotRm/zhvUw7DGgo3hldVJcTtIknzNfGOveA5hvguTkACC98E9vLc6H2dYg rRuJzTyJQvXBRSZVxqeodKugL5jElWUKiAGuuNc0= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16QJUsU5025904; Mon, 26 Jul 2021 19:30:56 +0000 In-Reply-To: <87h7ghku9w.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1D.60FF0D71.002D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=St3uF8G0 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=qxnCptG8Fm4groZ4cgEA:9 a=CjuIK1q_8ugA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210761 Archived-At: 26 juli 2021 kl. 19.06 skrev Juri Linkov : > my commit 9dc3a46a444a46e00ed3287a3174d73ed9511dac > was part of efforts to add column information to grep matches, > I added a funcall without incrementing its result by 1 > on the assumption that the function can return > an already inclusive result that doesn't need to offset by 1. Thank you for the thorough investigation! > Now your commit aa5437493b1ca539409495ecdc54cf420ea110b9 > broke the highlighting of columns in grep-regexp-alist, > so now visiting a grep match highlights an additional character > that is not part of the grep match. Good spotting! That one has now been fixed. > Maybe there are more existing functions whose backward-compatibility > is broken now. In preparation of my change I went through lots and lots of external = packages and found exactly none using a function for END-COL. This is = unsurprising since the very ability to use functions for COL and END-COL = wasn't documented until 2019. Somehow I missed grep.el, but that too makes sense -- it's inside Emacs = itself that the feature was most likely to be used since it was = undocumented. I have now gone through the source tree once more, and = there seem to be no more problems.