unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list'
@ 2015-03-30 17:36 Drew Adams
  2015-03-31 20:38 ` Juri Linkov
  2015-04-07 17:15 ` Paul Eggert
  0 siblings, 2 replies; 4+ messages in thread
From: Drew Adams @ 2015-03-30 17:36 UTC (permalink / raw)
  To: 20232

Please add a doc string.  Seems that if anything in `misearch.el'
deserves a doc string it is this variable.

This is presumably the easiest and best thing for code to test, to see
if Isearch is currently searching more than one buffer.  At least a
glance at the code gives me that impression.  It seems better, I'm
guessing, than testing either of these:

* (and multi-isearch-next-buffer-current-function
       (buffer-live-p multi-isearch-current-buffer))

* Option multi-isearch-search.


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list'
  2015-03-30 17:36 bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list' Drew Adams
@ 2015-03-31 20:38 ` Juri Linkov
  2015-04-02 16:21   ` Drew Adams
  2015-04-07 17:15 ` Paul Eggert
  1 sibling, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2015-03-31 20:38 UTC (permalink / raw)
  To: Drew Adams; +Cc: 20232

> Please add a doc string.  Seems that if anything in `misearch.el'
> deserves a doc string it is this variable.
>
> This is presumably the easiest and best thing for code to test, to see
> if Isearch is currently searching more than one buffer.  At least a
> glance at the code gives me that impression.  It seems better, I'm
> guessing, than testing either of these:
>
> * (and multi-isearch-next-buffer-current-function
>        (buffer-live-p multi-isearch-current-buffer))
>
> * Option multi-isearch-search.

You can see in `isearch-message-prefix' that `multi-isearch-file-list'
is used to test if Isearch is currently searching more than one file,
so do you need to have a doc string for `multi-isearch-file-list' as well?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list'
  2015-03-31 20:38 ` Juri Linkov
@ 2015-04-02 16:21   ` Drew Adams
  0 siblings, 0 replies; 4+ messages in thread
From: Drew Adams @ 2015-04-02 16:21 UTC (permalink / raw)
  To: Juri Linkov; +Cc: 20232

> You can see in `isearch-message-prefix' that `multi-isearch-file-list'
> is used to test if Isearch is currently searching more than one file,
> so do you need to have a doc string for `multi-isearch-file-list' as well?

Yes, I think so.  Thx.

(I've been using a build from 2014/10, where `isearch.el' does not refer to
`multi-search-file-list'.)





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list'
  2015-03-30 17:36 bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list' Drew Adams
  2015-03-31 20:38 ` Juri Linkov
@ 2015-04-07 17:15 ` Paul Eggert
  1 sibling, 0 replies; 4+ messages in thread
From: Paul Eggert @ 2015-04-07 17:15 UTC (permalink / raw)
  To: 20232-done

I gave a shot at documenting those vars as master commit 
29500239d3289803275ed6d4c774ab4488918564 and am marking this as done.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-07 17:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-30 17:36 bug#20232: 25.0.50; doc string of `multi-isearch-buffer-list' Drew Adams
2015-03-31 20:38 ` Juri Linkov
2015-04-02 16:21   ` Drew Adams
2015-04-07 17:15 ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).