* bug#18384: 24.3.93; posn-col-row and posn-actual-col-row return different row number for point-min when header-line-format is non-nil
@ 2014-09-01 21:13 Dmitry
2014-09-02 15:20 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry @ 2014-09-01 21:13 UTC (permalink / raw)
To: 18384
(Not a regression, same in Emacs 24.3 release, and apparently earlier versions).
1. Open a simple buffer; maybe an empty one.
2. (setq header-line-format "aaaa")
3. (posn-actual-col-row (posn-at-point (point-min)))
=> (0 . 1)
4. (posn-col-row (posn-at-point (point-min)))
=> (0 . -1)
I would also understand if the latter returned (0 . 0) instead of the
same value, but -1 seems obviously wrong.
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7390#40 ?
In GNU Emacs 24.3.93.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
of 2014-08-18 on axl
Repository revision: 117447 eliz@gnu.org-20140817144850-xgexz1n2z8s4aiur
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04.1 LTS
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#18384: 24.3.93; posn-col-row and posn-actual-col-row return different row number for point-min when header-line-format is non-nil
2014-09-01 21:13 bug#18384: 24.3.93; posn-col-row and posn-actual-col-row return different row number for point-min when header-line-format is non-nil Dmitry
@ 2014-09-02 15:20 ` Eli Zaretskii
2014-09-02 23:41 ` Dmitry Gutov
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2014-09-02 15:20 UTC (permalink / raw)
To: Dmitry; +Cc: 18384-done
> From: Dmitry <dgutov@yandex.ru>
> Date: Tue, 02 Sep 2014 01:13:03 +0400
>
> 1. Open a simple buffer; maybe an empty one.
> 2. (setq header-line-format "aaaa")
> 3. (posn-actual-col-row (posn-at-point (point-min)))
> => (0 . 1)
> 4. (posn-col-row (posn-at-point (point-min)))
> => (0 . -1)
>
> I would also understand if the latter returned (0 . 0) instead of the
> same value, but -1 seems obviously wrong.
They are both wrong. The correct result is (0 . 0), of course.
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7390#40 ?
Yes, this is indeed a fall-out of bug #7390. As you see in
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7390#49, the Y pixel
issue was fixed on the trunk (in r102407), but then my temporary
change in posn-col-row on the release branch, which shouldn't have
been merged onto the trunk, _was_ merged (in r102428) and screwed this
up. Reverting that change fixed posn-col-row.
As for posn-actual-col-row, the problem was in posn-at-point, which
was returning incorrect row count when header line is present in the
window. I fixed that as well.
Revision 117473 on the emacs-24 branch should fix both issues.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#18384: 24.3.93; posn-col-row and posn-actual-col-row return different row number for point-min when header-line-format is non-nil
2014-09-02 15:20 ` Eli Zaretskii
@ 2014-09-02 23:41 ` Dmitry Gutov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2014-09-02 23:41 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 18384-done
On 09/02/2014 07:20 PM, Eli Zaretskii wrote:
> Revision 117473 on the emacs-24 branch should fix both issues.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-02 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-01 21:13 bug#18384: 24.3.93; posn-col-row and posn-actual-col-row return different row number for point-min when header-line-format is non-nil Dmitry
2014-09-02 15:20 ` Eli Zaretskii
2014-09-02 23:41 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).