unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jarek Czekalski <jarek@jarek.katowice.pl>
To: 17408@debbugs.gnu.org
Subject: bug#17408: 24.4.50; tooltips make ms-window go top
Date: Tue, 06 May 2014 17:26:34 +0200	[thread overview]
Message-ID: <5368FF2A.5090408@jarek.katowice.pl> (raw)
In-Reply-To: <5368F5CD.2090504@poczta.onet.pl>

Eli,

Thanks for the quick review.

> But please use the SWP_* flags explicitly, I see
> no reason to define a special macro for 2 of them when all the rest
> are spelled out.

There are 2 reasons:
1. 78 chars limit is exceeded and code looks worse without the macro. 
It's less readable and it's more difficult to say which flags change 
between invocations.
2. These 2 flags wrapped in a def are of constant nature, they must be 
used with every call to SetWindowPos. Those out of def are not used in 
all invocations and their presence depends on other parameters (size, 
origin).

I'm preparing to commit the version without macros, but if you're quick 
you can change your mind :)

Jarek






  parent reply	other threads:[~2014-05-06 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 13:40 bug#17408: 24.4.50; tooltips make ms-window go top Jarek Czekalski
2014-05-05 13:56 ` Eli Zaretskii
2014-05-05 14:19 ` Jarek Czekalski
2014-05-05 14:47   ` Eli Zaretskii
2014-05-05 15:18     ` Jarek Czekalski
2014-05-05 15:42       ` Eli Zaretskii
2014-05-06 14:46 ` Jarek Czekalski
2014-05-06 15:08   ` Eli Zaretskii
2014-05-06 15:26   ` Jarek Czekalski [this message]
2014-05-06 16:06 ` Jarek Czekalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368FF2A.5090408@jarek.katowice.pl \
    --to=jarek@jarek.katowice.pl \
    --cc=17408@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).