From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jarek Czekalski Newsgroups: gmane.emacs.bugs Subject: bug#17408: 24.4.50; tooltips make ms-window go top Date: Tue, 06 May 2014 17:26:34 +0200 Message-ID: <5368FF2A.5090408@jarek.katowice.pl> References: <536794D9.9000406@poczta.onet.pl> <5368F5CD.2090504@poczta.onet.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1250; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1399413659 22680 80.91.229.3 (6 May 2014 22:00:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2014 22:00:59 +0000 (UTC) To: 17408@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 07 00:00:53 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WhnPl-00015O-Lv for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 May 2014 00:00:41 +0200 Original-Received: from localhost ([::1]:35969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhH6-0000yZ-Uf for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 May 2014 11:27:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhGw-0000yK-2m for bug-gnu-emacs@gnu.org; Tue, 06 May 2014 11:27:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhhGo-0007UL-JZ for bug-gnu-emacs@gnu.org; Tue, 06 May 2014 11:27:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhhGo-0007T6-GZ for bug-gnu-emacs@gnu.org; Tue, 06 May 2014 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WhhGn-0001Tv-QF for bug-gnu-emacs@gnu.org; Tue, 06 May 2014 11:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jarek Czekalski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 May 2014 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17408-submit@debbugs.gnu.org id=B17408.13993900035659 (code B ref 17408); Tue, 06 May 2014 15:27:01 +0000 Original-Received: (at 17408) by debbugs.gnu.org; 6 May 2014 15:26:43 +0000 Original-Received: from localhost ([127.0.0.1]:52977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WhhGU-0001TD-Te for submit@debbugs.gnu.org; Tue, 06 May 2014 11:26:43 -0400 Original-Received: from s74.linuxpl.com ([46.4.67.7]:56291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WhhGT-0001St-2a for 17408@debbugs.gnu.org; Tue, 06 May 2014 11:26:41 -0400 Original-Received: from cj.e-siemianowice.pl ([95.215.234.30] helo=[192.168.17.9]) by s74.linuxpl.com with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128) (Exim 4.80.1) (envelope-from ) id 1WhhGU-0005eX-0X for 17408@debbugs.gnu.org; Tue, 06 May 2014 17:26:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 In-Reply-To: <5368F5CD.2090504@poczta.onet.pl> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88645 Archived-At: Eli, Thanks for the quick review. > But please use the SWP_* flags explicitly, I see > no reason to define a special macro for 2 of them when all the rest > are spelled out. There are 2 reasons: 1. 78 chars limit is exceeded and code looks worse without the macro. It's less readable and it's more difficult to say which flags change between invocations. 2. These 2 flags wrapped in a def are of constant nature, they must be used with every call to SetWindowPos. Those out of def are not used in all invocations and their presence depends on other parameters (size, origin). I'm preparing to commit the version without macros, but if you're quick you can change your mind :) Jarek