unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37630@debbugs.gnu.org
Subject: bug#37630: 27.0.50; image-mode-fit-frame doesn't
Date: Wed, 23 Mar 2022 18:07:48 +0100	[thread overview]
Message-ID: <534dc98d-a307-f034-7cd5-151b76506efc@gmx.at> (raw)
In-Reply-To: <835yo4emmd.fsf@gnu.org>

 >>>> (set-frame-height nil (frame-pixel-height) nil t)
 >>>
 >>> Yes, it does here: the resulting frame is 2 lines taller.
 >>
 >> So it does here (with a non-toolkit build); I didn't notice.  (It does
 >> nothing in a Gtk build.)
 >>
 >> I guess that's a bug in `set-frame-height'?
 >
 > It could also be a feature.  Martin?

A silly one.  For historical reason, 'set-frame-height' expects a "text
height" as argument.  'frame-pixel-height' OTOH returns the "native
height" of the frame.  How these relate is explained in sections 30.3.1
and 30.3.4 of the Elisp Manual.  The idempotent operation you have in
mind is probably

(set-frame-height nil (frame-text-height) nil t)

although with a GTK build you usually won't notice the difference.

martin





  reply	other threads:[~2022-03-23 17:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-05  9:10 bug#37630: 27.0.50; image-mode-fit-frame doesn't Eli Zaretskii
2019-10-07  3:59 ` Lars Ingebrigtsen
2019-10-07  5:10   ` Eli Zaretskii
2019-10-07  5:15     ` Lars Ingebrigtsen
2019-10-07  5:31     ` Lars Ingebrigtsen
2019-10-07 16:25       ` Eli Zaretskii
2019-10-08  8:43         ` martin rudalics
2019-10-08  9:13           ` Eli Zaretskii
2019-10-08  9:25             ` martin rudalics
2019-10-08 11:53               ` Eli Zaretskii
2019-10-09 18:12                 ` martin rudalics
2019-10-08 15:47           ` Lars Ingebrigtsen
2019-10-08 16:02             ` Eli Zaretskii
2019-10-08 16:12               ` Lars Ingebrigtsen
2019-10-08 16:45                 ` Eli Zaretskii
2019-10-09 19:09                   ` Lars Ingebrigtsen
2022-03-23 13:18                     ` Lars Ingebrigtsen
2022-03-23 14:29                       ` Eli Zaretskii
2022-03-23 14:34                         ` Lars Ingebrigtsen
2022-03-23 14:35                           ` Lars Ingebrigtsen
2022-03-23 14:50                             ` Eli Zaretskii
2022-03-23 14:55                               ` Lars Ingebrigtsen
2022-03-23 15:04                                 ` Eli Zaretskii
2022-03-23 17:07                                   ` martin rudalics [this message]
2022-03-23 17:30                                     ` Lars Ingebrigtsen
2022-03-24  8:16                                       ` martin rudalics
2022-03-24  9:00                                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534dc98d-a307-f034-7cd5-151b76506efc@gmx.at \
    --to=rudalics@gmx.at \
    --cc=37630@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).