unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: 37630@debbugs.gnu.org
Subject: bug#37630: 27.0.50; image-mode-fit-frame doesn't
Date: Tue, 8 Oct 2019 10:43:51 +0200	[thread overview]
Message-ID: <0d475083-0f51-ed60-95f4-970fa67df241@gmx.at> (raw)
In-Reply-To: <83sgo4zfnf.fsf@gnu.org>

 > I hope Martin will help us out here.

If he only could (I don't use Emacs for images).  On my MSYS 64 bit
build, I can't display splash.svg getting the somewhat vague error

Using vacuous schema
Type C-c C-c or C-c C-x to view the image as an image or hex.
Cannot display image: (Invalid image specification)

When I instead try to display some jpg image here via C-x C-f I first
get a separate frame which is slightly larger than that image: When I
now do M-x image-mode-fit-frame in that frame, the frame resizes as
expected without any cropping.

Looking at the code of 'image-mode-fit-frame' I can't find anything
wrong with

	  (set-frame-height frame (+ (ceiling (cdr size))
				     height (- inner-height)))

and would be surprised if this failed unless some frame properties
changed in between the 'frame-height' and the 'window-inside-edges'
calls.  Maybe it's also the strange saving modus that interferes in
your setups.  The

			       (list (cons (frame-width)
					   (frame-height))

doesn't look like TRT when FRAME is not the selected frame but so far
I have no idea how this code is supposed to behave at all.  In either
case, make sure the 'image-mode-saved-params' parameter is nil before
calling 'image-mode-fit-frame'.

martin





  reply	other threads:[~2019-10-08  8:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-05  9:10 bug#37630: 27.0.50; image-mode-fit-frame doesn't Eli Zaretskii
2019-10-07  3:59 ` Lars Ingebrigtsen
2019-10-07  5:10   ` Eli Zaretskii
2019-10-07  5:15     ` Lars Ingebrigtsen
2019-10-07  5:31     ` Lars Ingebrigtsen
2019-10-07 16:25       ` Eli Zaretskii
2019-10-08  8:43         ` martin rudalics [this message]
2019-10-08  9:13           ` Eli Zaretskii
2019-10-08  9:25             ` martin rudalics
2019-10-08 11:53               ` Eli Zaretskii
2019-10-09 18:12                 ` martin rudalics
2019-10-08 15:47           ` Lars Ingebrigtsen
2019-10-08 16:02             ` Eli Zaretskii
2019-10-08 16:12               ` Lars Ingebrigtsen
2019-10-08 16:45                 ` Eli Zaretskii
2019-10-09 19:09                   ` Lars Ingebrigtsen
2022-03-23 13:18                     ` Lars Ingebrigtsen
2022-03-23 14:29                       ` Eli Zaretskii
2022-03-23 14:34                         ` Lars Ingebrigtsen
2022-03-23 14:35                           ` Lars Ingebrigtsen
2022-03-23 14:50                             ` Eli Zaretskii
2022-03-23 14:55                               ` Lars Ingebrigtsen
2022-03-23 15:04                                 ` Eli Zaretskii
2022-03-23 17:07                                   ` martin rudalics
2022-03-23 17:30                                     ` Lars Ingebrigtsen
2022-03-24  8:16                                       ` martin rudalics
2022-03-24  9:00                                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d475083-0f51-ed60-95f4-970fa67df241@gmx.at \
    --to=rudalics@gmx.at \
    --cc=37630@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).