* bug#16300: 24.3.50; 'M-<F10>' doesn't work always
@ 2013-12-30 12:02 Dani Moncayo
2014-01-04 9:33 ` martin rudalics
0 siblings, 1 reply; 4+ messages in thread
From: Dani Moncayo @ 2013-12-30 12:02 UTC (permalink / raw)
To: 16300
Recipe from "emacs -Q":
M-<F10> M-<F10> M-<F10>
The first time 'M-<F10>' is typed the emacs frame is maximized (OK), the
second time it is un-maximized (OK), but the third time nothing happens (it
should be maximized again).
In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
of 2013-12-29 on LEG570
Bzr revision: 115804 jan.h.d@swipnet.se-20131229131709-3xodjuaj5k14kpev
Windowing system distributor `Microsoft Corp.', version 6.3.9600
Configured using:
`configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'
--
Dani Moncayo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16300: 24.3.50; 'M-<F10>' doesn't work always
2013-12-30 12:02 bug#16300: 24.3.50; 'M-<F10>' doesn't work always Dani Moncayo
@ 2014-01-04 9:33 ` martin rudalics
2014-01-04 11:18 ` Dani Moncayo
0 siblings, 1 reply; 4+ messages in thread
From: martin rudalics @ 2014-01-04 9:33 UTC (permalink / raw)
To: Dani Moncayo; +Cc: 16300
> Recipe from "emacs -Q":
> M-<F10> M-<F10> M-<F10>
>
> The first time 'M-<F10>' is typed the emacs frame is maximized (OK), the
> second time it is un-maximized (OK), but the third time nothing happens (it
> should be maximized again).
Should behave better with revision 115865 on trunk. Please test it.
Thanks, martin
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16300: 24.3.50; 'M-<F10>' doesn't work always
2014-01-04 9:33 ` martin rudalics
@ 2014-01-04 11:18 ` Dani Moncayo
2014-01-04 13:43 ` martin rudalics
0 siblings, 1 reply; 4+ messages in thread
From: Dani Moncayo @ 2014-01-04 11:18 UTC (permalink / raw)
To: martin rudalics; +Cc: 16300
On Sat, Jan 4, 2014 at 10:33 AM, martin rudalics <rudalics@gmx.at> wrote:
>> Recipe from "emacs -Q":
>> M-<F10> M-<F10> M-<F10>
>>
>> The first time 'M-<F10>' is typed the emacs frame is maximized (OK), the
>> second time it is un-maximized (OK), but the third time nothing happens
>> (it
>> should be maximized again).
>
> Should behave better with revision 115865 on trunk. Please test it.
It seems fixed, indeed.
And BTW, I don't know if it's due to this change, but I can't
reproduce the bug #14239 anymore with the current trunk. So it could
be closed as well.
Thank you!
--
Dani Moncayo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16300: 24.3.50; 'M-<F10>' doesn't work always
2014-01-04 11:18 ` Dani Moncayo
@ 2014-01-04 13:43 ` martin rudalics
0 siblings, 0 replies; 4+ messages in thread
From: martin rudalics @ 2014-01-04 13:43 UTC (permalink / raw)
To: Dani Moncayo; +Cc: 16300-done
> It seems fixed, indeed.
The current code still doesn't catch all possible transitions. For
example, a FULLSCREEN_HEIGHT followed by two M-<F10>s will get you a
normalized window which is arguable not TRT but catching this without
introducing additional states seems hardly possible. Here I do
(defun toggle-full-height ()
(interactive)
(if (eq (frame-parameter nil 'fullscreen) 'fullheight)
(set-frame-parameter nil 'fullscreen 'fullnone)
(set-frame-parameter nil 'fullscreen 'fullheight)))
which IMO is the best way to use the FULLHEIGHT feature.
I'll close this bug.
> And BTW, I don't know if it's due to this change, but I can't
> reproduce the bug #14239 anymore with the current trunk.
The old code used SetWindowPos which according to
http://msdn.microsoft.com/en-us/library/windows/desktop/ms632611%28v=vs.85%29.aspx
should not be used:
The coordinates used in a WINDOWPLACEMENT structure should be used
only by the GetWindowPlacement and SetWindowPlacement
functions. Passing workspace coordinates to functions which expect
screen coordinates (such as SetWindowPos) will result in the window
appearing in the wrong location. For example, if the taskbar is at the
top of the screen, saving window coordinates using GetWindowPlacement
and restoring them using SetWindowPos causes the window to appear to
"creep" up the screen.
> So it could
> be closed as well.
Please do that.
martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-04 13:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-30 12:02 bug#16300: 24.3.50; 'M-<F10>' doesn't work always Dani Moncayo
2014-01-04 9:33 ` martin rudalics
2014-01-04 11:18 ` Dani Moncayo
2014-01-04 13:43 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).