From: Jarek Czekalski <jarekczek@poczta.onet.pl>
To: 15801@debbugs.gnu.org
Subject: bug#15801: 24.3.50; bar scrolling freezes gtk emacs
Date: Mon, 02 Dec 2013 09:04:59 +0100 [thread overview]
Message-ID: <529C3F2B.4090104@poczta.onet.pl> (raw)
In-Reply-To: <5277EA95.4070001@poczta.onet.pl>
Jan, you got lost with the commit 112892 of yours. You say it has
nothing to do with -nw, but in the message log you mention -nw. Please
have one more look at it (at the whole commit), to see that I'm right.
That's important, because I see a real problem with this commit.
When you created xgselect.c file in r98730 you placed the following
lines there:
| /* Update event sources in GLib. */
| g_main_context_pending (context);
As I understand it is that this call is important to update glib sources
(possibly glib file descriptors too - my guess).
In r109774 Paul removes this comment, while keeping the call to
g_main_context_pending, but conditionally:
+ if (! (x_in_use
+ && g_main_context_pending (context = g_main_context_default ())))
In r112892 you say that call to g_main_context_pending is not needed at
all, because it was a bad optimization, which you corrected.
This is a mistake, isn't it?
As a side note: I'm still trying to investigate my freeze. So far I know
that in the "freezed" state xgselect returns non-zero, while
XTread_socket returns 0. And this happens repeatedly and very quickly.
Side note 2: detailed description of the bug being fixed in a commit is
very important. Otherwise after just a few months we don't know what we
really fixed. A link to a bug report or to a discussion on a mailing
list would be very valueable. We don't have this information in commit
r112892.
Another concern when I analyze xgselect is why we increase the number of
tested selectors over the number requested by the caller? If a caller
receives a positive number, it thinks that there is something to read.
But it will check only the descriptors up to the number it specified in
the call. This doesn't make sense to me. Shouldn't it be specified in
the documentation of xgselect, that it may surprise caller with false
positives? This is not the usual behaviour of select-like calls, is it?
And this is something that was changed by your commit. Previously a
standard pselect was returned (under some circumstances). After that,
the extended version, with false positives.
Jarek
next prev parent reply other threads:[~2013-12-02 8:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 18:42 bug#15801: 24.3.50; bar scrolling freezes gtk emacs Jarek Czekalski
2013-11-05 12:57 ` bug#15801: 15801: commit identified Jarek Czekalski
2013-11-06 19:48 ` bug#15801: it's a different revision, 112892 Jarek Czekalski
2013-11-21 6:00 ` Jan Djärv
2013-11-21 7:25 ` bug#15801: 24.3.50; bar scrolling freezes gtk emacs Jarek Czekalski
2013-11-30 11:41 ` Jan Djärv
2013-11-30 11:54 ` Eli Zaretskii
2013-11-30 12:51 ` Jan Djärv
2013-11-30 13:55 ` Eli Zaretskii
2013-11-30 14:05 ` Jan Djärv
2013-11-30 18:11 ` Jarek Czekalski
2013-11-30 18:38 ` Eli Zaretskii
2013-11-30 17:04 ` Jarek Czekalski
2013-11-30 23:16 ` Jan Djärv
[not found] ` <529AF507.5080509@poczta.onet.pl>
[not found] ` <0440E2A5-37C6-4F29-9B5D-38A6AE88C3B5@swipnet.se>
[not found] ` <529B12DB.6020407@poczta.onet.pl>
2013-12-01 11:07 ` Jan Djärv
2013-12-01 11:38 ` Jarek Czekalski
2013-12-01 11:48 ` Jan Djärv
2013-11-30 17:10 ` bug#15801: 24.3.50; bar scrolling freezes gtk emacs - stdout warning Jarek Czekalski
2013-12-02 8:04 ` Jarek Czekalski [this message]
2013-12-02 8:18 ` bug#15801: 24.3.50; bar scrolling freezes gtk emacs Jarek Czekalski
2013-12-02 17:11 ` Jarek Czekalski
2013-12-03 22:27 ` Jarek Czekalski
2013-12-04 20:28 ` Jarek Czekalski
2013-12-05 17:08 ` Jarek Czekalski
2013-12-07 14:34 ` Jan Djärv
2013-12-08 16:14 ` Jarek Czekalski
2013-12-08 23:29 ` Jarek Czekalski
2013-12-11 19:52 ` Jan Djärv
2013-12-20 6:32 ` Jarek Czekalski
2013-12-20 8:58 ` Eli Zaretskii
2014-04-21 10:34 ` Jarek Czekalski
2014-04-21 15:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C3F2B.4090104@poczta.onet.pl \
--to=jarekczek@poczta.onet.pl \
--cc=15801@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).