From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jarek Czekalski Newsgroups: gmane.emacs.bugs Subject: bug#15801: 24.3.50; bar scrolling freezes gtk emacs Date: Mon, 02 Dec 2013 09:04:59 +0100 Message-ID: <529C3F2B.4090104@poczta.onet.pl> References: <5277EA95.4070001@poczta.onet.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385971574 26897 80.91.229.3 (2 Dec 2013 08:06:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Dec 2013 08:06:14 +0000 (UTC) To: 15801@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 09:06:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VnOWJ-0004hQ-Pg for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2013 09:06:20 +0100 Original-Received: from localhost ([::1]:34371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnOWJ-0002Zs-C0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2013 03:06:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnOWA-0002ZM-KY for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2013 03:06:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnOW3-0005lF-8z for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2013 03:06:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnOW2-0005kn-Px for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2013 03:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VnOW1-0005pX-RS for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2013 03:06:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <5277EA95.4070001@poczta.onet.pl> Resent-From: Jarek Czekalski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2013 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15801-submit@debbugs.gnu.org id=B15801.138597151322355 (code B ref 15801); Mon, 02 Dec 2013 08:06:01 +0000 Original-Received: (at 15801) by debbugs.gnu.org; 2 Dec 2013 08:05:13 +0000 Original-Received: from localhost ([127.0.0.1]:53944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnOVE-0005oT-0q for submit@debbugs.gnu.org; Mon, 02 Dec 2013 03:05:12 -0500 Original-Received: from smtpo11.poczta.onet.pl ([213.180.142.142]:47518) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnOV9-0005ns-3A for 15801@debbugs.gnu.org; Mon, 02 Dec 2013 03:05:09 -0500 Original-Received: from [192.168.17.9] (cj.e-siemianowice.pl [95.215.234.30]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jarekczek@poczta.onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 3dXzQ341BGz9ttjd for <15801@debbugs.gnu.org>; Mon, 2 Dec 2013 09:04:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.onet.pl; s=2011; t=1385971500; bh=LohbquY+btQ14wOZH0ScoFdJrb7tz62hTHp5Wv6EyxE=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type: Content-Transfer-Encoding; b=CwUBV/47VyPVgqBliL8/8dlQder55LHRnzReAsfRK0SM9A+LRocgkiKj8+YvjVLUj us37hhHx0Z1sC8PruzkpuDToKrD7Wf9jSGNfdpfTwvAyr+ioBPyneMflgm4zAI+CHH bKfxEIWKMZ8CHrULeeNt2+cUNZ64AQsAqEwDCfoY= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120824 Thunderbird/15.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81237 Archived-At: Jan, you got lost with the commit 112892 of yours. You say it has nothing to do with -nw, but in the message log you mention -nw. Please have one more look at it (at the whole commit), to see that I'm right. That's important, because I see a real problem with this commit. When you created xgselect.c file in r98730 you placed the following lines there: | /* Update event sources in GLib. */ | g_main_context_pending (context); As I understand it is that this call is important to update glib sources (possibly glib file descriptors too - my guess). In r109774 Paul removes this comment, while keeping the call to g_main_context_pending, but conditionally: + if (! (x_in_use + && g_main_context_pending (context = g_main_context_default ()))) In r112892 you say that call to g_main_context_pending is not needed at all, because it was a bad optimization, which you corrected. This is a mistake, isn't it? As a side note: I'm still trying to investigate my freeze. So far I know that in the "freezed" state xgselect returns non-zero, while XTread_socket returns 0. And this happens repeatedly and very quickly. Side note 2: detailed description of the bug being fixed in a commit is very important. Otherwise after just a few months we don't know what we really fixed. A link to a bug report or to a discussion on a mailing list would be very valueable. We don't have this information in commit r112892. Another concern when I analyze xgselect is why we increase the number of tested selectors over the number requested by the caller? If a caller receives a positive number, it thinks that there is something to read. But it will check only the descriptors up to the number it specified in the call. This doesn't make sense to me. Shouldn't it be specified in the documentation of xgselect, that it may surprise caller with false positives? This is not the usual behaviour of select-like calls, is it? And this is something that was changed by your commit. Previously a standard pselect was returned (under some circumstances). After that, the extended version, with false positives. Jarek