bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs

bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Code like the following breaks font-locking logic of ruby-mode:

expected_source = <<-END.strip_indent
              each do |x|
                some_method
                other_method
              end
            END


The second END gets highlighted as a constant, instead of a string. I guess the two consecutive ends cause the problem.

Here's a screenshot - http://i42.tinypic.com/122jeap.jpg

In GNU Emacs 24.3.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
 of 2013-08-12 on Bozhidars-MacBook-Pro.local
Windowing system distributor `Apple', version 10.3.1187
Configured using:
 `configure '--prefix=/usr/local/Cellar/emacs/24.3' '--without-dbus'
 '--enable-locallisppath=/usr/local/share/emacs/site-lisp'
 '--infodir=/usr/local/Cellar/emacs/24.3/share/info/emacs'
 '--without-gnutls' '--with-ns' '--disable-ns-self-contained' 'CC=cc''



-- 
Cheers,
Bozhidar


[-- Attachment #2: Type: text/html, Size: 1612 bytes --]

bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs

[Dmitry Gutov]

Bozhidar Batsov <bozhidar.batsov@gmail.com> writes:

> Code like the following breaks font-locking logic of ruby-mode:
>
> expected_source = <<-END.strip_indent
> each do |x|
> some_method
> other_method
> end
> END
>
> The second END gets highlighted as a constant, instead of a string. I
> guess the two consecutive ends cause the problem.
>
> Here's a screenshot - http://i42.tinypic.com/122jeap.jpg

WFM: http://i.imgur.com/YPsjoDS.png

Have you tried it in the current trunk?

The first END highlighting looks out of place, but it's caused by the
"Perl-ish keywords" rule.

bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

I guess this is fixed in the trunk, but I think the highlighting of the first END in the heredoc should be corrected as well.

-- 
Cheers,
Bozhidar


On Thursday, September 5, 2013 at 2:45 PM, Dmitry Gutov wrote:

> Bozhidar Batsov <bozhidar.batsov@gmail.com (mailto:bozhidar.batsov@gmail.com)> writes:
> 
> > Code like the following breaks font-locking logic of ruby-mode:
> > 
> > expected_source = <<-END.strip_indent
> > each do |x|
> > some_method
> > other_method
> > end
> > END
> > 
> > The second END gets highlighted as a constant, instead of a string. I
> > guess the two consecutive ends cause the problem.
> > 
> > Here's a screenshot - http://i42.tinypic.com/122jeap.jpg
> 
> WFM: http://i.imgur.com/YPsjoDS.png
> 
> Have you tried it in the current trunk?
> 
> The first END highlighting looks out of place, but it's caused by the
> "Perl-ish keywords" rule.
> 
> 



[-- Attachment #2: Type: text/html, Size: 1858 bytes --]

bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs

[Dmitry Gutov]

Version: 24.4

On 05.09.2013 14:48, Bozhidar Batsov wrote:
> I guess this is fixed in the trunk, but I think the highlighting of the
> first END in the heredoc should be corrected as well.

Ok, fixed for heredocs (gave BEGIN/END lower priority).