bug#12822: python.el, python-indent-guess-indent-offset

bug#12822: python.el, python-indent-guess-indent-offset

[Andreas Röhler]

Hi,

with current python.el

python-indent-guess-indent-offset proceeds:

(defun python-indent-guess-indent-offset ()
   "Guess and set `python-indent-offset' for the current buffer."
   (interactive)
   (save-excursion
     (save-restriction
       (widen)
       (goto-char (point-min))
       (let ((block-end))
         (while (and (not block-end)
                     (re-search-forward
                      (python-rx line-start block-start) nil t))
                      [...]


IIUC it fetches the first beginning of block in buffer.
As in Python every block might have it's own ideas WRT
volume of indent-step, this must fail when
indent-offset is set differently in current block.

Guessing must not take the first block from BOB, but
the next beginning of block from point upward.

IMO as it's just a guess, where the default-value might
be delivered, it also should not call `widen'.

Best,

Andreas

bug#12822: (no subject)

[Fabián Ezequiel Gallina]

The whole idea of python-indent-guess-indent-offset is to provide some 
sane default at find-file. The decision of making the indentation of 
first available block the default indentation is intended and it's not 
going to change. This way indentation guessing behaves consistently all 
the time and the user is able to modify the first block so the command 
plays nice to him after next file visit.

Also, as a side note, all blocks in a python file should be indented the 
same way, the only special case would be an if triggered into multiple 
lines using parens like this but this case is not that common that I'm 
not even worrying about:

     if (something and
         somethingelse and
         otherstuff):
             pass