* bug#11880: 24.1.50; `even-window-heights' should be nil by default
@ 2012-07-08 17:03 Dmitry Gutov
[not found] ` <handler.11880.B.134176734523092.ack@debbugs.gnu.org>
2012-08-25 14:57 ` bug#11880: 24.1.50; `even-window-heights' should be nil by default martin rudalics
0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Gutov @ 2012-07-08 17:03 UTC (permalink / raw)
To: 11880
As mentioned in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11810,
I believe that the behavior enabled by this variable is non-intuitive
and inconsistent.
Many users have become used to it, but looks like the majority just
doesn't know how to disable it. Example:
http://stackoverflow.com/questions/4716855/how-can-i-prevent-emacs-resizing-my-windows
A question to people who like it as it is: what's the idea behind the
window position limitations? Why only resize when the used window is
vertically adjacent to the selected, and only when below it?
Why not resize independent of position, as long as the used window is inside
some vertically split combination?
As alternative to disabling it by default, I propose to
1) Make `window--even-window-heights' resize any window as long as that
would only move the window(s) in the same combination (or something like
that).
2) Restore the original window height on `quit-window'. This amounts to
the following code at the end of `display-buffer-user-some-window':
(when window
(prog1
(window--display-buffer buffer window 'reuse)
(window--even-window-heights window)))
--Dmitry
GNU Emacs 24.1.50.1 (i386-mingw-nt6.1.7601) of 2012-07-06
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#11880: Acknowledgement (24.1.50; `even-window-heights' should be nil by default)
[not found] ` <handler.11880.B.134176734523092.ack@debbugs.gnu.org>
@ 2012-07-12 18:52 ` Dmitry Gutov
2012-08-25 14:57 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2012-07-12 18:52 UTC (permalink / raw)
To: 11880
Oh, and by the way, `even-window-heights' docstring is incorrect.
It says: "Heights are evened only when `display-buffer' chooses a
window that appears above or below the selected window."
Whereas heights will only be evened if the chosen window is below the
selected window.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#11880: 24.1.50; `even-window-heights' should be nil by default
2012-07-08 17:03 bug#11880: 24.1.50; `even-window-heights' should be nil by default Dmitry Gutov
[not found] ` <handler.11880.B.134176734523092.ack@debbugs.gnu.org>
@ 2012-08-25 14:57 ` martin rudalics
2012-08-25 22:28 ` Dmitry Gutov
1 sibling, 1 reply; 6+ messages in thread
From: martin rudalics @ 2012-08-25 14:57 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 11880
> As alternative to disabling it by default, I propose to
> 1) Make `window--even-window-heights' resize any window as long as that
> would only move the window(s) in the same combination (or something like
> that).
I now resize only when WINDOW and the selected window form a combination.
> 2) Restore the original window height on `quit-window'. This amounts to
> the following code at the end of `display-buffer-user-some-window':
>
> (when window
> (prog1
> (window--display-buffer buffer window 'reuse)
> (window--even-window-heights window)))
It should do that now.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#11880: Acknowledgement (24.1.50; `even-window-heights' should be nil by default)
2012-07-12 18:52 ` bug#11880: Acknowledgement (24.1.50; `even-window-heights' should be nil by default) Dmitry Gutov
@ 2012-08-25 14:57 ` martin rudalics
0 siblings, 0 replies; 6+ messages in thread
From: martin rudalics @ 2012-08-25 14:57 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 11880
> Oh, and by the way, `even-window-heights' docstring is incorrect.
>
> It says: "Heights are evened only when `display-buffer' chooses a
> window that appears above or below the selected window."
> Whereas heights will only be evened if the chosen window is below the
> selected window.
It now should even in either case.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#11880: 24.1.50; `even-window-heights' should be nil by default
2012-08-25 14:57 ` bug#11880: 24.1.50; `even-window-heights' should be nil by default martin rudalics
@ 2012-08-25 22:28 ` Dmitry Gutov
2012-08-27 9:16 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2012-08-25 22:28 UTC (permalink / raw)
To: martin rudalics; +Cc: 11880
On 25.08.2012 18:57, martin rudalics wrote:
> > As alternative to disabling it by default, I propose to
> > 1) Make `window--even-window-heights' resize any window as long as that
> > would only move the window(s) in the same combination (or something like
> > that).
>
> I now resize only when WINDOW and the selected window form a combination.
>
> > 2) Restore the original window height on `quit-window'. This amounts to
> > the following code at the end of `display-buffer-user-some-window':
> >
> > (when window
> > (prog1
> > (window--display-buffer buffer window 'reuse)
> > (window--even-window-heights window)))
>
> It should do that now.
Indeed, the behavior is much better now. Thanks!
--Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#11880: 24.1.50; `even-window-heights' should be nil by default
2012-08-25 22:28 ` Dmitry Gutov
@ 2012-08-27 9:16 ` martin rudalics
0 siblings, 0 replies; 6+ messages in thread
From: martin rudalics @ 2012-08-27 9:16 UTC (permalink / raw)
To: 11880-done; +Cc: Dmitry Gutov
> Indeed, the behavior is much better now. Thanks!
The behavior is since revision 109773 on trunk. Bug closed.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-27 9:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-08 17:03 bug#11880: 24.1.50; `even-window-heights' should be nil by default Dmitry Gutov
[not found] ` <handler.11880.B.134176734523092.ack@debbugs.gnu.org>
2012-07-12 18:52 ` bug#11880: Acknowledgement (24.1.50; `even-window-heights' should be nil by default) Dmitry Gutov
2012-08-25 14:57 ` martin rudalics
2012-08-25 14:57 ` bug#11880: 24.1.50; `even-window-heights' should be nil by default martin rudalics
2012-08-25 22:28 ` Dmitry Gutov
2012-08-27 9:16 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).