* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
@ 2013-11-25 19:13 Drew Adams
2014-02-08 3:10 ` Lars Ingebrigtsen
0 siblings, 1 reply; 14+ messages in thread
From: Drew Adams @ 2013-11-25 19:13 UTC (permalink / raw)
To: 15974
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
See attached screenshot, for emacs -Q -nw, of a Customize buffer, showing
color-name fields and face fields.
"What were they thinking?" is what anyone looking at this should think.
All user input fields, including the giant search field, are BRIGHT YELLOW.
On a black background, no less.
A much better color choice for this would be something like `lightgray' or
`darkgray'. This is nuts. Hard to believe that no one has complained
about this before now, or that it has not been corrected before now.
In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
of 2013-11-20 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'
[-- Attachment #2: throw-emacs-nw-awful-bg.png --]
[-- Type: image/png, Size: 34288 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2013-11-25 19:13 bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW Drew Adams
@ 2014-02-08 3:10 ` Lars Ingebrigtsen
2014-02-08 9:10 ` Eli Zaretskii
2014-02-08 23:02 ` Drew Adams
0 siblings, 2 replies; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-08 3:10 UTC (permalink / raw)
To: Drew Adams; +Cc: 15974
Drew Adams <drew.adams@oracle.com> writes:
> See attached screenshot, for emacs -Q -nw, of a Customize buffer, showing
> color-name fields and face fields.
>
> "What were they thinking?" is what anyone looking at this should think.
> All user input fields, including the giant search field, are BRIGHT YELLOW.
> On a black background, no less.
It does look kinda stark, yes. Is this only with -nw?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-08 3:10 ` Lars Ingebrigtsen
@ 2014-02-08 9:10 ` Eli Zaretskii
2014-02-08 10:24 ` Lars Ingebrigtsen
2014-02-08 23:02 ` Drew Adams
1 sibling, 1 reply; 14+ messages in thread
From: Eli Zaretskii @ 2014-02-08 9:10 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 07 Feb 2014 19:10:30 -0800
> Cc: 15974@debbugs.gnu.org
>
> Drew Adams <drew.adams@oracle.com> writes:
>
> > See attached screenshot, for emacs -Q -nw, of a Customize buffer, showing
> > color-name fields and face fields.
> >
> > "What were they thinking?" is what anyone looking at this should think.
> > All user input fields, including the giant search field, are BRIGHT YELLOW.
> > On a black background, no less.
>
> It does look kinda stark, yes. Is this only with -nw?
Did you (Lars) succeed in reproducing this display? Because I
couldn't. A recipe for reproducing this would go a long way towards
resolving this issue, one way or another.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-08 9:10 ` Eli Zaretskii
@ 2014-02-08 10:24 ` Lars Ingebrigtsen
2014-02-08 10:57 ` Eli Zaretskii
0 siblings, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-08 10:24 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 15974
Eli Zaretskii <eliz@gnu.org> writes:
>> It does look kinda stark, yes. Is this only with -nw?
>
> Did you (Lars) succeed in reproducing this display? Because I
> couldn't. A recipe for reproducing this would go a long way towards
> resolving this issue, one way or another.
No, I was not able to reproduce it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-08 10:24 ` Lars Ingebrigtsen
@ 2014-02-08 10:57 ` Eli Zaretskii
0 siblings, 0 replies; 14+ messages in thread
From: Eli Zaretskii @ 2014-02-08 10:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: drew.adams@oracle.com, 15974@debbugs.gnu.org
> Date: Sat, 08 Feb 2014 02:24:30 -0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> It does look kinda stark, yes. Is this only with -nw?
> >
> > Did you (Lars) succeed in reproducing this display? Because I
> > couldn't. A recipe for reproducing this would go a long way towards
> > resolving this issue, one way or another.
>
> No, I was not able to reproduce it.
Well, perhaps Drew could tell how he got that buffer.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-08 3:10 ` Lars Ingebrigtsen
2014-02-08 9:10 ` Eli Zaretskii
@ 2014-02-08 23:02 ` Drew Adams
2014-02-09 2:24 ` Lars Ingebrigtsen
1 sibling, 1 reply; 14+ messages in thread
From: Drew Adams @ 2014-02-08 23:02 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> > See attached screenshot, for emacs -Q -nw, of a Customize buffer,
> > showing color-name fields and face fields.
> >
> > "What were they thinking?" is what anyone looking at this should
> > think. All user input fields, including the giant search field,
> > are BRIGHT YELLOW. On a black background, no less.
>
> It does look kinda stark, yes. Is this only with -nw?
I think so.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-08 23:02 ` Drew Adams
@ 2014-02-09 2:24 ` Lars Ingebrigtsen
2014-02-10 0:57 ` Drew Adams
0 siblings, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-09 2:24 UTC (permalink / raw)
To: Drew Adams; +Cc: 15974
Drew Adams <drew.adams@oracle.com> writes:
>> > See attached screenshot, for emacs -Q -nw, of a Customize buffer,
>> > showing color-name fields and face fields.
>> >
>> > "What were they thinking?" is what anyone looking at this should
>> > think. All user input fields, including the giant search field,
>> > are BRIGHT YELLOW. On a black background, no less.
>>
>> It does look kinda stark, yes. Is this only with -nw?
>
> I think so.
I seem to be unable to find where these offending faces are. What were
you trying to customize exactly?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-09 2:24 ` Lars Ingebrigtsen
@ 2014-02-10 0:57 ` Drew Adams
2014-02-10 2:44 ` Lars Ingebrigtsen
0 siblings, 1 reply; 14+ messages in thread
From: Drew Adams @ 2014-02-10 0:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> >> > See attached screenshot, for emacs -Q -nw, of a Customize
> >> > buffer, showing color-name fields and face fields.
> >> >
> >> > "What were they thinking?" is what anyone looking at this
> >> > should think. All user input fields, including the giant
> >> > search field, are BRIGHT YELLOW. On a black background,
> >> > no less.
> >>
> >> It does look kinda stark, yes. Is this only with -nw?
> >
> > I think so.
>
> I seem to be unable to find where these offending faces are.
> What were you trying to customize exactly?
Lars, you are missing the point. It is not the colors of the
_faces_ that are awful. It is the colors of the "color-name
fields and face fields". It is the EDITING FIELDS that use
the awful bright-yellow.
---
But if you are for some reason interested in the code that
defines the option, this is it:
(defcustom hlt-auto-face-backgrounds
(let ((tty-cols (hlt-tty-colors))
(tty-faces (hlt-remove-if-not #'facep
'(highlight isearch isearch-fail lazy-highlight
mode-line mode-line-inactive next-error
nobreak-space secondary-selection tooltip
trailing-whitespace))))
(if (display-graphic-p)
(append tty-cols
'("DeepPink" "MediumPurple1" "SpringGreen1"
"DarkOrange" "HotPink1")
tty-faces
(hlt-remove-if-not
#'facep '(header-line mode-line-highlight)))
(append tty-cols tty-faces)))
"..."
:type '(repeat (choice
(color :tag "Background color" :value "yellow")
(face :tag "Face" :value "highlight")))
:group 'highlight)
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
[not found] ` <<83zjm2vuk1.fsf@gnu.org>
@ 2014-02-10 1:01 ` Drew Adams
0 siblings, 0 replies; 14+ messages in thread
From: Drew Adams @ 2014-02-10 1:01 UTC (permalink / raw)
To: Eli Zaretskii, Lars Ingebrigtsen; +Cc: 15974
> Did you (Lars) succeed in reproducing this display? Because I
> couldn't. A recipe for reproducing this would go a long way towards
> resolving this issue, one way or another.
See my reply to Lars. It is the _editing fields_ that use the
bright yellow color inappropriately (from emacs -Q -nw, on MS
Windows). It is not the face colors that are in question.
If you need to repro it for some reason, just load this library:
http://www.emacswiki.org/emacs-en/download/highlight.el
The option shown in the screenshot is `hlt-auto-face-backgrounds'.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-10 0:57 ` Drew Adams
@ 2014-02-10 2:44 ` Lars Ingebrigtsen
2014-02-10 3:03 ` Drew Adams
0 siblings, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10 2:44 UTC (permalink / raw)
To: Drew Adams; +Cc: 15974
Drew Adams <drew.adams@oracle.com> writes:
>> I seem to be unable to find where these offending faces are.
>> What were you trying to customize exactly?
>
> Lars, you are missing the point. It is not the colors of the
> _faces_ that are awful. It is the colors of the "color-name
> fields and face fields". It is the EDITING FIELDS that use
> the awful bright-yellow.
I was asking for a recipe to demonstrate the problem. It's not an
entirely novel idea, I would have thought?
> But if you are for some reason interested in the code that
> defines the option, this is it:
>
> (defcustom hlt-auto-face-backgrounds
> (let ((tty-cols (hlt-tty-colors))
What on Earth is `hlt-auto-face-backgrounds'? I can't find any such
symbol in the Emacs tree.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-10 2:44 ` Lars Ingebrigtsen
@ 2014-02-10 3:03 ` Drew Adams
2014-02-10 3:06 ` Lars Ingebrigtsen
[not found] ` <83y51iubdy.fsf@gnu.org>
0 siblings, 2 replies; 14+ messages in thread
From: Drew Adams @ 2014-02-10 3:03 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> I was asking for a recipe to demonstrate the problem. It's not an
> entirely novel idea, I would have thought?
As I replied to Eli:
http://www.emacswiki.org/emacs-en/download/highlight.el
The option shown in the screenshot is `hlt-auto-face-backgrounds'.
> What on Earth is `hlt-auto-face-backgrounds'? I can't find any
> such symbol in the Emacs tree.
Yes, Virginia; there is a Santa Claus. There is a world of Emacs
code beyond the Emacs tree. ;-)
In that file, you will find the defcustom, which was also in the
mail you are replying to. That defcustom and these 2 functions
are all you need to repro the bug and see for yourself:
(defun hlt-tty-colors ()
"Colors available for use with Emacs in a terminal (`emacs -nw')."
(hlt-remove-if-not
#'x-color-defined-p
(if (fboundp 'tty-color-alist)
(mapcar #'car (tty-color-alist))
'("blue" "green" "cyan" "red" "magenta" "brown" "lightgray" "darkgray"
"yellow" "white" "lightblue" "lightgreen" "lightcyan" "lightred"
"lightmagenta"))))
(defun hlt-remove-if-not (pred xs)
"A copy of list XS with only elements that satisfy predicate PRED."
(let ((result ()))
(dolist (x xs) (when (funcall pred x) (push x result)))
(nreverse result)))
Be sure to start with emacs -Q -nw. Use `C-u C-x =' on the yellow
fields and you will see they use face `widget-field'. That is the
face that needs fixing, IMO.
But again, this bug has nothing to do with the code in that file.
It is the Customize _edit fields_ that are bright yellow.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-10 3:03 ` Drew Adams
@ 2014-02-10 3:06 ` Lars Ingebrigtsen
2014-02-10 3:14 ` Drew Adams
[not found] ` <83y51iubdy.fsf@gnu.org>
1 sibling, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10 3:06 UTC (permalink / raw)
To: Drew Adams; +Cc: 15974
Drew Adams <drew.adams@oracle.com> writes:
> Be sure to start with emacs -Q -nw. Use `C-u C-x =' on the yellow
> fields and you will see they use face `widget-field'. That is the
> face that needs fixing, IMO.
Now that's a good bug report. >"?
;; TTY gets special definitions here and in the next defface, because
;; the gray colors defined for other displays cause black text on a black
;; background, at least on light-background TTYs.
(defface widget-field '((((type tty))
:background "yellow3"
:foreground "black")
(((class grayscale color)
(background light))
:background "gray85")
(((class grayscale color)
(background dark))
:background "dim gray")
(t
:slant italic))
So that's the explanation for the black on yellow. Surely there are
other colours that could work on a tty.
Drew, could you try experimenting to find a pleasing colour combination?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
2014-02-10 3:06 ` Lars Ingebrigtsen
@ 2014-02-10 3:14 ` Drew Adams
0 siblings, 0 replies; 14+ messages in thread
From: Drew Adams @ 2014-02-10 3:14 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 15974
> Drew, could you try experimenting to find a pleasing colour
> combination?
I prefer not to. I use neither a tty (-nw) nor a dark background.
Better to get someone who is used to one of those to choose.
FWIW, I'm OK with whatever color you choose. Even if you pick
the same yellow. ;-) The bug report was to draw attention to
the problem. If someone looks at it and says that this yellow
is the best that can be done, that's fine with me. At least
someone will have looked into it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW
[not found] ` <3ad5abea-959f-46b1-90f2-527df4d7f52e@default>
@ 2014-02-11 3:33 ` Eli Zaretskii
0 siblings, 0 replies; 14+ messages in thread
From: Eli Zaretskii @ 2014-02-11 3:33 UTC (permalink / raw)
To: Drew Adams; +Cc: larsi, 15974-done
> Date: Mon, 10 Feb 2014 13:22:52 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: larsi@gnus.org, 15974-don@debbugs.gnu.org
>
> > Let's agree to disagree on this.
>
> Sure.
>
> > (FWIW, I see nothing wrong with the existing color to begin with.)
>
> And I am clearly no spokesperson for tty use or dark background use.
> It is fine with me if this is closed with no changes. Thanks for
> looking into it, though.
Closing.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-02-11 3:33 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 19:13 bug#15974: 24.3.50; emacs -Q -nw: awful color for input fields: BRIGHT YELLOW Drew Adams
2014-02-08 3:10 ` Lars Ingebrigtsen
2014-02-08 9:10 ` Eli Zaretskii
2014-02-08 10:24 ` Lars Ingebrigtsen
2014-02-08 10:57 ` Eli Zaretskii
2014-02-08 23:02 ` Drew Adams
2014-02-09 2:24 ` Lars Ingebrigtsen
2014-02-10 0:57 ` Drew Adams
2014-02-10 2:44 ` Lars Ingebrigtsen
2014-02-10 3:03 ` Drew Adams
2014-02-10 3:06 ` Lars Ingebrigtsen
2014-02-10 3:14 ` Drew Adams
[not found] ` <83y51iubdy.fsf@gnu.org>
[not found] ` <0087db25-ff93-4dd9-822c-41afd1746dbf@default>
[not found] ` <83ppmuu910.fsf@gnu.org>
[not found] ` <3ad5abea-959f-46b1-90f2-527df4d7f52e@default>
2014-02-11 3:33 ` Eli Zaretskii
[not found] <<4f10904c-6fb1-470f-a2fd-0032209f80dc@default>
[not found] ` <<87iosq9u55.fsf@building.gnus.org>
[not found] ` <<83zjm2vuk1.fsf@gnu.org>
2014-02-10 1:01 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).