bug#53482: Byte-code speedup [PATCH]

bug#53482: Byte-code speedup [PATCH]

[Mattias Engdegård]

The branch scratch/bytecode-speedup now contains a set of related improvements to speed up the byte-code interpreter. If someone is allergic to Git, I could post them as separate patches.

Performance is improved in many ways but is mostly focussed on making Elisp's lamentably slow function calls faster, which should benefit a lot of code. Operations on fixnums have also been sped up, as well as some data structure access.

Equally importantly, the C stack requirements has shrunk meaning that users can recurse deeper before getting a segfault. For example, bytecode is no longer copied to a stack buffer for execution. I intend to carry this process further in a set of follow-up patches, but the current changes are definitely good enough on their own.

I have run a wide set of benchmarks; regressions are rare but obviously not all code benefits equally. Most code becomes at least a little faster.

Unless there are good arguments not to, I'll merge it to master shortly.

bug#53482: Byte-code speedup [PATCH]

[Lars Ingebrigtsen]

Mattias Engdegård <mattiase@acm.org> writes:

> The branch scratch/bytecode-speedup now contains a set of related
> improvements to speed up the byte-code interpreter. If someone is
> allergic to Git, I could post them as separate patches.

Perhaps Stefan M has some comments; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#53482: Byte-code speedup [PATCH]

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> The branch scratch/bytecode-speedup now contains a set of related
>> improvements to speed up the byte-code interpreter. If someone is
>> allergic to Git, I could post them as separate patches.
> Perhaps Stefan M has some comments; added to the CCs.

I already sent him my comments on earlier (private) rounds ;-)
I like those patches.


        Stefan

bug#53482: Byte-code speedup [PATCH]

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> The branch scratch/bytecode-speedup now contains a set of related
>>> improvements to speed up the byte-code interpreter. If someone is
>>> allergic to Git, I could post them as separate patches.
>> Perhaps Stefan M has some comments; added to the CCs.
>
> I already sent him my comments on earlier (private) rounds ;-)
> I like those patches.

Then please go ahead and merge, Mattias.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#53482: Byte-code speedup [PATCH]

[Dmitry Gutov]

On 23.01.2022 18:57, Mattias Engdegård wrote:
> I have run a wide set of benchmarks; regressions are rare but obviously not all code benefits equally. Most code becomes at least a little faster.

I'm seeing ~3% improvement in a js2-mode benchmark. Not revolutionary, 
but nothing to sneeze at.

Thanks, Mattias.

bug#53482: Byte-code speedup [PATCH]

[Dmitry Gutov]

On 24.01.2022 00:20, Dmitry Gutov wrote:
> I'm seeing ~3% improvement in a js2-mode benchmark.

And if I'm ensure the loaded code is byte-compiled, the difference comes 
up to ~13% (though the variance is high). Nice.

bug#53482: Byte-code speedup [PATCH]

[Mattias Engdegård]

23 jan. 2022 kl. 22.30 skrev Lars Ingebrigtsen <larsi@gnus.org>:

> Then please go ahead and merge, Mattias.

Thank you, pushed to master.