* bug#8828: unsigned casts in PTR_BYTE_POS and BUF_PTR_BYTE_POS
@ 2011-06-09 6:54 Paul Eggert
2011-12-31 8:37 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggert @ 2011-06-09 6:54 UTC (permalink / raw)
To: 8828
Currently, src/buffer.h's macros PTR_BYTE_POS and BUF_PTR_BYTE_POS
both cast subexpressions to 'unsigned'. This can't
be right on a 64-bit host, since the subexpressions might
exceed 2**32 if the buffer is large, and their values shouldn't
be truncated to 32 bits.
I can't see why the cast to 'unsigned' is there at all,
even on a 32-bit host; unless I'm missing something
the values being compared are always nonnegative.
So I'd like to install the following
patch into the trunk, after some testing.
=== modified file 'src/buffer.h'
--- src/buffer.h 2011-06-06 19:43:39 +0000
+++ src/buffer.h 2011-06-09 04:04:41 +0000
@@ -337,7 +337,7 @@
#define PTR_BYTE_POS(ptr) \
((ptr) - (current_buffer)->text->beg \
- - (ptr - (current_buffer)->text->beg <= (unsigned) (GPT_BYTE - BEG_BYTE) ? 0 : GAP_SIZE) \
+ - (ptr - (current_buffer)->text->beg <= GPT_BYTE - BEG_BYTE ? 0 : GAP_SIZE) \
+ BEG_BYTE)
/* Return character at byte position POS. */
@@ -396,7 +396,7 @@
#define BUF_PTR_BYTE_POS(buf, ptr) \
((ptr) - (buf)->text->beg \
- - (ptr - (buf)->text->beg <= (unsigned) (BUF_GPT_BYTE ((buf)) - BEG_BYTE)\
+ - (ptr - (buf)->text->beg <= BUF_GPT_BYTE ((buf)) - BEG_BYTE \
? 0 : BUF_GAP_SIZE ((buf))) \
+ BEG_BYTE)
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#8828: unsigned casts in PTR_BYTE_POS and BUF_PTR_BYTE_POS
2011-06-09 6:54 bug#8828: unsigned casts in PTR_BYTE_POS and BUF_PTR_BYTE_POS Paul Eggert
@ 2011-12-31 8:37 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2011-12-31 8:37 UTC (permalink / raw)
To: 8828-done
This bug was fixed in bzr 104599 in the trunk, dated 2011-06-15.
I forgot to close it then but am closing it now.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-31 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-09 6:54 bug#8828: unsigned casts in PTR_BYTE_POS and BUF_PTR_BYTE_POS Paul Eggert
2011-12-31 8:37 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).