unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David De La Harpe Golden <david@harpegolden.net>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 9874@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#9874: Fixes for several integer overflow and width issues
Date: Wed, 26 Oct 2011 18:02:22 +0100	[thread overview]
Message-ID: <4EA83D1E.8040203@harpegolden.net> (raw)
In-Reply-To: <CAAeL0SRxqnSA3wKRkHK3KhjMfi8N4qkTACX5Yk6zfMfjuw4PTg@mail.gmail.com>

On 26/10/11 15:26, Juanma Barranquero wrote:
>> Thank you very much, but we're too far in the release process for such
>> large patches, so it will have to wait for 24.2.
>
> These bugs seem serious enough:
>
>      - On my Fedora 14 x86-64 host, (signal-process 4294967295 1)
>        crashes my entire login session, Emacs included, and leaves my
>        workstation in a corrupted state in which the screen
>        continually flashes a nonsense pattern and I cannot log in.
>        This bug occurs because Emacs incorrectly assumes that fixnums
>        fit into pid_t values, which is not true on typical 64-bit hosts.
>

Hmm. The really serious/horrible part there (screen manglement and being 
unable to login again) sounds like some X and/or [gkx]dm bug well 
outside emacs' responsibility.  Given the current state of the emacs 
code, it should "just" kill (hup) all the processes you can kill*.  It 
shouldn't be any worse than if you just opened up an xterm and typed 
"kill -HUP -1".

Yes, that probably includes suddenly ending your entire desktop session, 
but unless you're running as a privileged user that should "just" leave 
you staring in annoyance at the [gkx]dm login dialog, there shouldn't be 
any lingering corruption, just like there shouldn't be any lingering 
corruption with a "kill -HUP -1".

Emacs bug that 4294967295 silently/surprisingly becomes -1 in 
signal-process? Well, probably. Emacs bug that your computer's state 
somehow gets corrupted to the point you can't log in again?  No.


*  pid_t 32-bit, 4294967295 => 32-bit -1, and kill(-1,...) signals 
everything you're allowed signal.





  reply	other threads:[~2011-10-26 17:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26  7:51 bug#9874: Fixes for several integer overflow and width issues Paul Eggert
2011-10-26  8:04 ` Andreas Schwab
2011-10-26 14:09 ` Stefan Monnier
2011-10-26 14:26   ` Juanma Barranquero
2011-10-26 17:02     ` David De La Harpe Golden [this message]
2011-10-26 17:16     ` Stefan Monnier
2011-10-26 19:22       ` Andreas Schwab
2011-10-27  6:33   ` Paul Eggert
2011-10-27  8:28     ` Andreas Schwab
2011-10-27 15:14       ` Paul Eggert
2012-04-09 23:38     ` Paul Eggert
2012-05-25 20:50       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA83D1E.8040203@harpegolden.net \
    --to=david@harpegolden.net \
    --cc=9874@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).