From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David De La Harpe Golden Newsgroups: gmane.emacs.bugs Subject: bug#9874: Fixes for several integer overflow and width issues Date: Wed, 26 Oct 2011 18:02:22 +0100 Message-ID: <4EA83D1E.8040203@harpegolden.net> References: <4EA7BBE9.4020107@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1319648613 27885 80.91.229.12 (26 Oct 2011 17:03:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 26 Oct 2011 17:03:33 +0000 (UTC) Cc: 9874@debbugs.gnu.org, Paul Eggert To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 26 19:03:26 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RJ6sv-00009B-3z for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Oct 2011 19:03:25 +0200 Original-Received: from localhost ([::1]:47627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ6st-0005J2-AR for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Oct 2011 13:03:23 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ6sq-0005HN-1r for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2011 13:03:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ6so-0008QJ-Th for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2011 13:03:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ6so-0008QE-O4 for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2011 13:03:18 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RJ6uU-0000La-9w for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2011 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David De La Harpe Golden Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2011 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9874-submit@debbugs.gnu.org id=B9874.13196486511272 (code B ref 9874); Wed, 26 Oct 2011 17:05:02 +0000 Original-Received: (at 9874) by debbugs.gnu.org; 26 Oct 2011 17:04:11 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJ6te-0000KT-RZ for submit@debbugs.gnu.org; Wed, 26 Oct 2011 13:04:11 -0400 Original-Received: from harpegolden.net ([65.99.215.13]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RJ6tc-0000KK-Nw for 9874@debbugs.gnu.org; Wed, 26 Oct 2011 13:04:09 -0400 Original-Received: from [87.198.47.56] (87-198-47-56.ptr.magnet.ie [87.198.47.56]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client CN "David De La Harpe Golden", Issuer "David De La Harpe Golden Personal CA rev 3" (verified OK)) by harpegolden.net (Postfix) with ESMTPSA id 8C3D7683A2; Wed, 26 Oct 2011 18:02:23 +0100 (IST) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Icedove/3.1.15 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 26 Oct 2011 13:05:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53156 Archived-At: On 26/10/11 15:26, Juanma Barranquero wrote: >> Thank you very much, but we're too far in the release process for such >> large patches, so it will have to wait for 24.2. > > These bugs seem serious enough: > > - On my Fedora 14 x86-64 host, (signal-process 4294967295 1) > crashes my entire login session, Emacs included, and leaves my > workstation in a corrupted state in which the screen > continually flashes a nonsense pattern and I cannot log in. > This bug occurs because Emacs incorrectly assumes that fixnums > fit into pid_t values, which is not true on typical 64-bit hosts. > Hmm. The really serious/horrible part there (screen manglement and being unable to login again) sounds like some X and/or [gkx]dm bug well outside emacs' responsibility. Given the current state of the emacs code, it should "just" kill (hup) all the processes you can kill*. It shouldn't be any worse than if you just opened up an xterm and typed "kill -HUP -1". Yes, that probably includes suddenly ending your entire desktop session, but unless you're running as a privileged user that should "just" leave you staring in annoyance at the [gkx]dm login dialog, there shouldn't be any lingering corruption, just like there shouldn't be any lingering corruption with a "kill -HUP -1". Emacs bug that 4294967295 silently/surprisingly becomes -1 in signal-process? Well, probably. Emacs bug that your computer's state somehow gets corrupted to the point you can't log in again? No. * pid_t 32-bit, 4294967295 => 32-bit -1, and kill(-1,...) signals everything you're allowed signal.