bug#9168: 24.0.50; x-popup-dialog can freeze Emacs on OS X

bug#9168: 24.0.50; x-popup-dialog can freeze Emacs on OS X

[Ivan Andrus]

From emacs -Q evaluating:

(x-popup-dialog t "hi")

will bring up a dialog with no way to dismiss it and no way to close it.  I have to force quit Emacs.  I can only test it on OS X right now.

I realize this is not the proper way to invoke x-popup-dialog, but something similar seems to be the cause of a problem that just happened to me in Customize.  I cannot reproduce it now, but ns_popup_dialog was in the gdb backtrace (which I foolishly didn't save), so I tried just running x-popup-dialog before reading the docstring and ran across this.  In the problem that I saw from inside customize I did not see a dialog at all, but the other symptoms were the same, so it may be that the dialog was displayed off screen where I simply couldn't dismiss it.



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Users/gvol/vcs/emacs/local/nextstep/Emacs.app/Contents/Resources/etc/DEBUG.


In GNU Emacs 24.0.50.6 (i386-apple-darwin10.8.0, NS apple-appkit-1038.36)
of 2011-07-25 on oroszlan.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  highlight-parentheses-mode: t
  highlight-symbol-mode: t
  hi-lock-mode: t
  drag-stuff-global-mode: t
  drag-stuff-mode: t
  eldoc-mode: t
  hl-sexp-mode: t
  which-function-mode: t
  show-paren-mode: t
  recentf-mode: t
  msb-mode: t
  ido-everywhere: t
  global-hl-line-mode: t
  delete-selection-mode: t
  auto-image-file-mode: t
  auto-insert-mode: t
  yas/global-mode: t
  global-visible-mark-mode: t
  visible-mark-mode: t
  gvol-mode: t
  desktop-save-mode: t
  command-frequency-autosave-mode: t
  command-frequency-mode: t
  itunes-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
y M-x e m a c s <tab> r e <tab> <backspace> <backspace> 
C-g M-x r e p o <tab> r <tab> <return>

Recent messages:
Making completion list...
Desktop lazily opening results.gap (5 remaining)...
tex now compiling remotely
tex now compiling locally
Current project is tex
iTunes not running
Desktop lazily opening results.gap (5 remaining)...done
Desktop lazily opening trac.org (4 remaining)...
iTunes not running
Desktop lazily opening trac.org (4 remaining)...done

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message rfc822 mml mml-sec mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
mail-utils gmm-utils mailheader subword emacsbug gvol-light-theme
sage-mode compile ansi-color python-21 python gap-mode gap-process
highlight-parentheses highlight-symbol hi-lock drag-stuff eldoc hl-sexp
thingatpt greedy-delete vc-hg reveal org-habit org-wl org-w3m org-vm
org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs org-html org-exp
ob-exp org-exp-blocks org-info org-gnus org-docview org-bibtex org-bbdb
org-agenda ob-python org ob-emacs-lisp ob-tangle ob-ref ob-lob ob-table
org-footnote org-src ob-comint comint ring ob-keys ob ob-eval
org-complete pcomplete org-list org-faces org-compat org-entities
org-macs noutline outline auctex-autoloads tex-site info
drag-stuff-autoloads highlight-parentheses-autoloads
highlight-symbol-autoloads speck-autoloads xml-rpc-autoloads package
tabulated-list saveplace uniquify jka-compr which-func imenu paren
recentf tree-widget wid-edit msb ido icomplete hl-line delsel image-file
cus-start cus-load diary-lib diary-loaddefs cal-menu calendar
cal-loaddefs warnings autoinsert yasnippet dropdown-list derived edmacro
kmacro help-mode view tramp tramp-compat auth-source eieio byte-opt
bytecomp byte-compile cconv macroexp gnus-util mm-util mail-prsvr
password-cache format-spec tramp-loaddefs visible-mark parenface fold cl
xml desktop browse-kill-ring backtr command-frequency uptimes pp server
easy-mmode assoc dired+ dired-x easymenu ediff-merg ediff-diff
ediff-wind ediff-mult ediff-help ediff-init ediff-util dired-aux dired
regexp-opt advice help-fns advice-preload windmove time-date tooltip
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer loaddefs button faces cus-face files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)

bug#9168: 24.0.50; x-popup-dialog can freeze Emacs on OS X

[Jan Djärv]

Hello.

I checked in a fix so x-popup-dialog behaves the same as the X11 versions of 
Emacs, i.e.: (x-popup-dialog t "hi") throws an error, and if no buttons have 
been specified, as in (x-popup-dialog t '("hi")), an "Ok" button is shown.

	Jan D.


Ivan Andrus skrev 2011-07-25 16:37:
>  From emacs -Q evaluating:
>
> (x-popup-dialog t "hi")
>
> will bring up a dialog with no way to dismiss it and no way to close it.  I have to force quit Emacs.  I can only test it on OS X right now.
>
> I realize this is not the proper way to invoke x-popup-dialog, but something similar seems to be the cause of a problem that just happened to me in Customize.  I cannot reproduce it now, but ns_popup_dialog was in the gdb backtrace (which I foolishly didn't save), so I tried just running x-popup-dialog before reading the docstring and ran across this.  In the problem that I saw from inside customize I did not see a dialog at all, but the other symptoms were the same, so it may be that the dialog was displayed off screen where I simply couldn't dismiss it.
>
>
>
> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>      `bt full' and `xbacktrace'.
> For information about debugging Emacs, please read the file
> /Users/gvol/vcs/emacs/local/nextstep/Emacs.app/Contents/Resources/etc/DEBUG.
>
>
> In GNU Emacs 24.0.50.6 (i386-apple-darwin10.8.0, NS apple-appkit-1038.36)
> of 2011-07-25 on oroszlan.local
> Windowing system distributor `Apple', version 10.3.1038
> configured using `configure  '--with-ns''
>
> Important settings:
>    value of $LC_ALL: nil
>    value of $LC_COLLATE: nil
>    value of $LC_CTYPE: nil
>    value of $LC_MESSAGES: nil
>    value of $LC_MONETARY: nil
>    value of $LC_NUMERIC: nil
>    value of $LC_TIME: nil
>    value of $LANG: nil
>    value of $XMODIFIERS: nil
>    locale-coding-system: nil
>    default enable-multibyte-characters: t
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>    highlight-parentheses-mode: t
>    highlight-symbol-mode: t
>    hi-lock-mode: t
>    drag-stuff-global-mode: t
>    drag-stuff-mode: t
>    eldoc-mode: t
>    hl-sexp-mode: t
>    which-function-mode: t
>    show-paren-mode: t
>    recentf-mode: t
>    msb-mode: t
>    ido-everywhere: t
>    global-hl-line-mode: t
>    delete-selection-mode: t
>    auto-image-file-mode: t
>    auto-insert-mode: t
>    yas/global-mode: t
>    global-visible-mark-mode: t
>    visible-mark-mode: t
>    gvol-mode: t
>    desktop-save-mode: t
>    command-frequency-autosave-mode: t
>    command-frequency-mode: t
>    itunes-mode: t
>    tooltip-mode: t
>    mouse-wheel-mode: t
>    tool-bar-mode: t
>    menu-bar-mode: t
>    file-name-shadow-mode: t
>    global-font-lock-mode: t
>    font-lock-mode: t
>    blink-cursor-mode: t
>    auto-composition-mode: t
>    auto-encryption-mode: t
>    auto-compression-mode: t
>    column-number-mode: t
>    line-number-mode: t
>    transient-mark-mode: t
>
> Recent input:
> y M-x e m a c s<tab>  r e<tab>  <backspace>  <backspace>
> C-g M-x r e p o<tab>  r<tab>  <return>
>
> Recent messages:
> Making completion list...
> Desktop lazily opening results.gap (5 remaining)...
> tex now compiling remotely
> tex now compiling locally
> Current project is tex
> iTunes not running
> Desktop lazily opening results.gap (5 remaining)...done
> Desktop lazily opening trac.org (4 remaining)...
> iTunes not running
> Desktop lazily opening trac.org (4 remaining)...done
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr message rfc822 mml mml-sec mm-decode mm-bodies
> mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
> mail-utils gmm-utils mailheader subword emacsbug gvol-light-theme
> sage-mode compile ansi-color python-21 python gap-mode gap-process
> highlight-parentheses highlight-symbol hi-lock drag-stuff eldoc hl-sexp
> thingatpt greedy-delete vc-hg reveal org-habit org-wl org-w3m org-vm
> org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs org-html org-exp
> ob-exp org-exp-blocks org-info org-gnus org-docview org-bibtex org-bbdb
> org-agenda ob-python org ob-emacs-lisp ob-tangle ob-ref ob-lob ob-table
> org-footnote org-src ob-comint comint ring ob-keys ob ob-eval
> org-complete pcomplete org-list org-faces org-compat org-entities
> org-macs noutline outline auctex-autoloads tex-site info
> drag-stuff-autoloads highlight-parentheses-autoloads
> highlight-symbol-autoloads speck-autoloads xml-rpc-autoloads package
> tabulated-list saveplace uniquify jka-compr which-func imenu paren
> recentf tree-widget wid-edit msb ido icomplete hl-line delsel image-file
> cus-start cus-load diary-lib diary-loaddefs cal-menu calendar
> cal-loaddefs warnings autoinsert yasnippet dropdown-list derived edmacro
> kmacro help-mode view tramp tramp-compat auth-source eieio byte-opt
> bytecomp byte-compile cconv macroexp gnus-util mm-util mail-prsvr
> password-cache format-spec tramp-loaddefs visible-mark parenface fold cl
> xml desktop browse-kill-ring backtr command-frequency uptimes pp server
> easy-mmode assoc dired+ dired-x easymenu ediff-merg ediff-diff
> ediff-wind ediff-mult ediff-help ediff-init ediff-util dired-aux dired
> regexp-opt advice help-fns advice-preload windmove time-date tooltip
> ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
> image fringe lisp-mode register page menu-bar rfn-eshadow timer select
> scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
> georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
> korean japanese hebrew greek romanian slovak czech european ethiopic
> indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
> abbrev minibuffer loaddefs button faces cus-face files text-properties
> overlay sha1 md5 base64 format env code-pages mule custom widget
> hashtable-print-readable backquote make-network-process ns multi-tty
> emacs)
>
>