unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>, 9031@debbugs.gnu.org
Subject: bug#9031: Installed rest of patch
Date: Mon, 11 Jul 2011 10:25:56 -0700	[thread overview]
Message-ID: <4E1B3224.5050804@cs.ucla.edu> (raw)
In-Reply-To: <jwvmxglrnmj.fsf-monnier+emacs@gnu.org>

On 07/11/11 05:49, Stefan Monnier wrote:
> it's better to keep code cleanups for later

This particular fix is both a code cleanup and a bug fix.
The latter, because often compilers complain about unused
local variables, and we'd rather have Emacs builds that
don't have useless chatter and generate bug reports that
waste everybody's time later.

Compiler warnings are a judgment call.  Pacifying
every compiler would be a never-ending task, and we shouldn't
try to do that.  But this particular case is a trivial and
obviously-safe change, and it fixes GCC warnings about
code that was introduced after the feature freeze.
The (admittedly minor) benefit of such a change surely
exceeds its cost.

I'd prefer it if, when one builds Emacs, one gets no more
compile-time diagnostics than one did when the feature
freeze was introduced.  This shouldn't be an absolute goal
and it shouldn't stand in the way of more-important issues,
but surely it's not an unreasonable aspiration.

> you could
> try to install them in the `pending' branch, but such code cleanups are
> likely to generate merge conflicts

Does this advice mean that code cleanups should not be installed
anywhere now, not even in the 'pending' branch?  I ask because I
have some integer-overflow-and-signedness-related cleanups and
bug-fixes in my private copy that should really get incorporated
at some point.

(Sorry, I don't know the current practice with regards to the
'pending' branch; maybe 'pending' should be documented somewhere
under admin/?)





  reply	other threads:[~2011-07-11 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09  6:32 bug#9031: Unused vars etc. in chartab.c, composite.c, gtkutil.c Paul Eggert
2011-07-10  5:21 ` bug#9031: Installed rest of patch Paul Eggert
2011-07-10 11:37   ` Juanma Barranquero
2011-07-11 12:49     ` Stefan Monnier
2011-07-11 17:25       ` Paul Eggert [this message]
2011-07-12  4:51         ` Stefan Monnier
2011-07-12  5:36           ` Paul Eggert
2011-07-12 11:07           ` Juanma Barranquero
2011-07-12 15:44             ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1B3224.5050804@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=9031@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).