From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#9031: Installed rest of patch Date: Mon, 11 Jul 2011 10:25:56 -0700 Organization: UCLA Computer Science Department Message-ID: <4E1B3224.5050804@cs.ucla.edu> References: <4E17F5F8.7060200@cs.ucla.edu> <4E1936D7.4030302@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1310406349 2937 80.91.229.12 (11 Jul 2011 17:45:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 11 Jul 2011 17:45:49 +0000 (UTC) Cc: Juanma Barranquero , 9031@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 11 19:45:45 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QgKYA-0007ny-V7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jul 2011 19:45:43 +0200 Original-Received: from localhost ([::1]:42863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgKY9-0002EK-Mc for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jul 2011 13:45:42 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgKG8-0006Qe-Pq for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2011 13:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgKG6-0007UQ-Su for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2011 13:27:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgKG6-0007UB-Bm for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2011 13:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QgKG5-0006k4-Mp; Mon, 11 Jul 2011 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2011 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9031 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9031-submit@debbugs.gnu.org id=B9031.131040516625848 (code B ref 9031); Mon, 11 Jul 2011 17:27:01 +0000 Original-Received: (at 9031) by debbugs.gnu.org; 11 Jul 2011 17:26:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgKFC-0006ir-5w for submit@debbugs.gnu.org; Mon, 11 Jul 2011 13:26:06 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgKF9-0006iN-KF for 9031@debbugs.gnu.org; Mon, 11 Jul 2011 13:26:04 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 751F639E80F7; Mon, 11 Jul 2011 10:25:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hmFEtuDn6-x3; Mon, 11 Jul 2011 10:25:56 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DE69B39E80F0; Mon, 11 Jul 2011 10:25:56 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 11 Jul 2011 13:27:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48629 Archived-At: On 07/11/11 05:49, Stefan Monnier wrote: > it's better to keep code cleanups for later This particular fix is both a code cleanup and a bug fix. The latter, because often compilers complain about unused local variables, and we'd rather have Emacs builds that don't have useless chatter and generate bug reports that waste everybody's time later. Compiler warnings are a judgment call. Pacifying every compiler would be a never-ending task, and we shouldn't try to do that. But this particular case is a trivial and obviously-safe change, and it fixes GCC warnings about code that was introduced after the feature freeze. The (admittedly minor) benefit of such a change surely exceeds its cost. I'd prefer it if, when one builds Emacs, one gets no more compile-time diagnostics than one did when the feature freeze was introduced. This shouldn't be an absolute goal and it shouldn't stand in the way of more-important issues, but surely it's not an unreasonable aspiration. > you could > try to install them in the `pending' branch, but such code cleanups are > likely to generate merge conflicts Does this advice mean that code cleanups should not be installed anywhere now, not even in the 'pending' branch? I ask because I have some integer-overflow-and-signedness-related cleanups and bug-fixes in my private copy that should really get incorporated at some point. (Sorry, I don't know the current practice with regards to the 'pending' branch; maybe 'pending' should be documented somewhere under admin/?)