* bug#5056: Minor fix for a defcustom in savehist mode (patch included)
@ 2009-11-27 6:39 ` Ryan C. Thompson
2009-11-30 23:45 ` bug#5056: marked as done (Minor fix for a defcustom in savehist mode (patch included)) Emacs bug Tracking System
0 siblings, 1 reply; 2+ messages in thread
From: Ryan C. Thompson @ 2009-11-27 6:39 UTC (permalink / raw)
To: bug-gnu-emacs
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
While customizing savehist mode through the emacs Custom interface, I
discovered that I could not set `savehist-autosave-interval' to nil
because the custom buffer only had an integer entry field for that
variable, although the docstring said that nil was a valid value. So I
edited the custom definition to allow choosing either nil or an integer,
instead of just an integer. I also added labels to the two choices to
make things clearer for the user. Here is the one-line diff (assuming
that it doesn't get too badly mangled in transit):
BEGIN DIFF
*** old/savehist.el 2009-11-26 21:47:52.378311830 -0800
--- new/savehist.el 2009-11-26 21:19:12.118518476 -0800
***************
*** 120,126 ****
(defcustom savehist-autosave-interval (* 5 60)
"The interval between autosaves of minibuffer history.
If set to nil, disables timer-based autosaving."
! :type 'integer
:group 'savehist)
(defcustom savehist-mode-hook nil
--- 120,127 ----
(defcustom savehist-autosave-interval (* 5 60)
"The interval between autosaves of minibuffer history.
If set to nil, disables timer-based autosaving."
! :type '(choice (const :tag "Disabled" nil)
! (integer :tag "Seconds" 300))
:group 'savehist)
(defcustom savehist-mode-hook nil
END DIFF
Here is my attempt at manually writing a changelog entry:
BEGIN CHANGELOG
2009-11-62 Ryan C. Thompson <rct@thompsonclan.org>
* savehist.el: Allow setting `savehist-autosave-interval'
to nil in Custom.
END CHANGELOG
If it matters, you have my blessing to license this code however you please.
- Ryan Thompson
[-- Attachment #2: Re: minor bugfix for savehist mode.eml --]
[-- Type: message/rfc822, Size: 2599 bytes --]
From: Hrvoje Niksic <hniksic@xemacs.org>
To: "Ryan C. Thompson" <rct@thompsonclan.org>
Subject: Re: minor bugfix for savehist mode
Date: Mon, 31 Aug 2009 13:37:23 +0200
Message-ID: <87pracgqoc.fsf@busola.homelinux.net>
"Ryan C. Thompson" <rct@thompsonclan.org> writes:
> I would like to submit a minor improvement for savehist mode. I
> noticed that the variable savehist-autosave-interval could be either
> an integer or nil, but its definition allowed it to be customized only
> as an integer. I changed the definition to allow it to also be set to
> nil in Custom.
Please post your bugfix to Emacs maintainers so it gets incorporated
into the next release. I no longer actively maintain savehist-mode.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#5056: marked as done (Minor fix for a defcustom in savehist mode (patch included))
2009-11-27 6:39 ` bug#5056: Minor fix for a defcustom in savehist mode (patch included) Ryan C. Thompson
@ 2009-11-30 23:45 ` Emacs bug Tracking System
0 siblings, 0 replies; 2+ messages in thread
From: Emacs bug Tracking System @ 2009-11-30 23:45 UTC (permalink / raw)
To: Juanma Barranquero
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
Your message dated Tue, 1 Dec 2009 00:39:47 +0100
with message-id <f7ccd24b0911301539iba50be9l3c0973167a06b190@mail.gmail.com>
and subject line Re: bug#5056: Minor fix for a defcustom in savehist mode (patch included)
has caused the Emacs bug report #5056,
regarding Minor fix for a defcustom in savehist mode (patch included)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
5056: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5056
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 7003 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 1628 bytes --]
While customizing savehist mode through the emacs Custom interface, I
discovered that I could not set `savehist-autosave-interval' to nil
because the custom buffer only had an integer entry field for that
variable, although the docstring said that nil was a valid value. So I
edited the custom definition to allow choosing either nil or an integer,
instead of just an integer. I also added labels to the two choices to
make things clearer for the user. Here is the one-line diff (assuming
that it doesn't get too badly mangled in transit):
BEGIN DIFF
*** old/savehist.el 2009-11-26 21:47:52.378311830 -0800
--- new/savehist.el 2009-11-26 21:19:12.118518476 -0800
***************
*** 120,126 ****
(defcustom savehist-autosave-interval (* 5 60)
"The interval between autosaves of minibuffer history.
If set to nil, disables timer-based autosaving."
! :type 'integer
:group 'savehist)
(defcustom savehist-mode-hook nil
--- 120,127 ----
(defcustom savehist-autosave-interval (* 5 60)
"The interval between autosaves of minibuffer history.
If set to nil, disables timer-based autosaving."
! :type '(choice (const :tag "Disabled" nil)
! (integer :tag "Seconds" 300))
:group 'savehist)
(defcustom savehist-mode-hook nil
END DIFF
Here is my attempt at manually writing a changelog entry:
BEGIN CHANGELOG
2009-11-62 Ryan C. Thompson <rct@thompsonclan.org>
* savehist.el: Allow setting `savehist-autosave-interval'
to nil in Custom.
END CHANGELOG
If it matters, you have my blessing to license this code however you please.
- Ryan Thompson
[-- Attachment #2.1.2: Re: minor bugfix for savehist mode.eml --]
[-- Type: message/rfc822, Size: 2599 bytes --]
From: Hrvoje Niksic <hniksic@xemacs.org>
To: "Ryan C. Thompson" <rct@thompsonclan.org>
Subject: Re: minor bugfix for savehist mode
Date: Mon, 31 Aug 2009 13:37:23 +0200
Message-ID: <87pracgqoc.fsf@busola.homelinux.net>
"Ryan C. Thompson" <rct@thompsonclan.org> writes:
> I would like to submit a minor improvement for savehist mode. I
> noticed that the variable savehist-autosave-interval could be either
> an integer or nil, but its definition allowed it to be customized only
> as an integer. I changed the definition to allow it to also be set to
> nil in Custom.
Please post your bugfix to Emacs maintainers so it gets incorporated
into the next release. I no longer actively maintain savehist-mode.
Thank you.
[-- Attachment #3: Type: message/rfc822, Size: 2508 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: "Ryan C. Thompson" <rct@thompsonclan.org>
Cc: 5056-done@emacsbugs.donarmstrong.com
Subject: Re: bug#5056: Minor fix for a defcustom in savehist mode (patch included)
Date: Tue, 1 Dec 2009 00:39:47 +0100
Message-ID: <f7ccd24b0911301539iba50be9l3c0973167a06b190@mail.gmail.com>
On Fri, Nov 27, 2009 at 07:39, Ryan C. Thompson <rct@thompsonclan.org> wrote:
> make things clearer for the user. Here is the one-line diff (assuming
> that it doesn't get too badly mangled in transit):
Applied, thanks.
Juanma
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-30 23:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <f7ccd24b0911301539iba50be9l3c0973167a06b190@mail.gmail.com>
2009-11-27 6:39 ` bug#5056: Minor fix for a defcustom in savehist mode (patch included) Ryan C. Thompson
2009-11-30 23:45 ` bug#5056: marked as done (Minor fix for a defcustom in savehist mode (patch included)) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).