bug#2172: ico bug on Windows

bug#2172: ico bug on Windows

[Chong Yidong]

David Robinow <drobinow@gmail.com> has reported a build failure on MS
Visual Studio, apparently due to change in the Windows icon file format.

David Robinow <drobinow@gmail.com> writes:

> Microsoft Visual Studio .NET 2003 fails at:
>
> rc -i../nt -Foobj-spd/i386/emacs.res ../nt/emacs.rc
> ../nt/emacs.rc(1) : error RC2176 : old DIB in icons\emacs.ico; pass it
> through SDKPAINT
>
> This error has been present ever since the new icon was added.  I'd
> forgotten about it since I reverted to the Emacs 22 icon for my daily
> builds.  I don't know a good fix.

bug#2172: ico bug on Windows

[Jason Rumney]

Chong Yidong wrote:
> David Robinow <drobinow@gmail.com> has reported a build failure on MS
> Visual Studio, apparently due to change in the Windows icon file format.
>   

I think it is time to stop caring about MS Visual Studio. GCC has been 
available for Windows for close to 10 years now.

bug#2172: ico bug on Windows

[Eli Zaretskii]

> From: Jason Rumney <jasonr@gnu.org>
> Cc: emacs-pretest-bug@gnu.org, David Robinow <drobinow@gmail.com>
> 
> Chong Yidong wrote:
> > David Robinow <drobinow@gmail.com> has reported a build failure on MS
> > Visual Studio, apparently due to change in the Windows icon file format.
> >   
> 
> I think it is time to stop caring about MS Visual Studio. GCC has been 
> available for Windows for close to 10 years now.

If we decide to do that, we should state the non-support in NEWS and
in nt/INSTALL.

bug#2172: ico bug on Windows

[David Robinow]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Mon, Feb 2, 2009 at 7:06 PM, Jason Rumney <jasonr@gnu.org> wrote:
> Chong Yidong wrote:
>>
>> David Robinow <drobinow@gmail.com> has reported a build failure on MS
>> Visual Studio, apparently due to change in the Windows icon file format.
>>
>
> I think it is time to stop caring about MS Visual Studio. GCC has been
> available for Windows for close to 10 years now.
>
You won't get any argument from me. I only compile with it because
nobody else seemed to. I use gcc on three of my four Windows machines.

I have created an icon that works, sort of. I used png2ico.exe (GPL)
from http://www.winterdrache.de/freeware/png2ico/
It looked good enough on my XP system, but not so great on Vista
compared to the original. Perhaps it can be included as an option for
use with MSVC.
After overwriting emacs.ico the compile works fine. (Of course, it's a
simple matter to change the desktop shortcuts back to the original
icon)

[-- Attachment #2: emacs.ico.2003 --]
[-- Type: application/octet-stream, Size: 19518 bytes --]

bug#2172: ico bug on Windows

[Chong Yidong]

David Robinow <drobinow@gmail.com> writes:

> I have created an icon that works, sort of. I used png2ico.exe (GPL)
> from http://www.winterdrache.de/freeware/png2ico/ It looked good
> enough on my XP system, but not so great on Vista compared to the
> original. Perhaps it can be included as an option for use with MSVC.
> After overwriting emacs.ico the compile works fine. (Of course, it's a
> simple matter to change the desktop shortcuts back to the original
> icon)

Jason, would it be possible for you to try changing the .ico file, along
the lines described by David, so that the MS compiler is happy with it?
Normally we should not go out of our way to accomodate MS Visual studio,
but this seems to be a moderately easy fix.

If you can't fix this and/or would prefer to drop support for MSVS
instead, could you please update nt/INSTALL and etc/PROBLEMS with the
information in this bug report?  Thanks.

bug#2172: ico bug on Windows

[Jason Rumney]

Chong Yidong wrote:
> Jason, would it be possible for you to try changing the .ico file, along
> the lines described by David, so that the MS compiler is happy with it?
> Normally we should not go out of our way to accomodate MS Visual studio,
> but this seems to be a moderately easy fix.
>   

I don't think providing an inferior icon is a good fix just for the one 
or two people who still compile Emacs with outdated proprietary compilers.

> If you can't fix this and/or would prefer to drop support for MSVS
> instead, could you please update nt/INSTALL and etc/PROBLEMS with the
> information in this bug report?  Thanks.


I've already detailed the workarounds in etc/PROBLEMS.

bug#2172: marked as done (ico bug on Windows)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]


Your message dated Wed, 04 Feb 2009 18:28:16 +0900
with message-id <49895FB0.8030409@gnu.org>
and subject line Re: bug#2168: MSVC 2003 Resource Compiler Error
has caused the Emacs bug report #2168,
regarding ico bug on Windows
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2168: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2168
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2632 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: emacs-pretest-bug@gnu.org
Cc: David Robinow <drobinow@gmail.com>
Subject: ico bug on Windows
Date: Mon, 02 Feb 2009 16:56:28 -0500
Message-ID: <87myd4h59v.fsf_-_@cyd.mit.edu>

David Robinow <drobinow@gmail.com> has reported a build failure on MS
Visual Studio, apparently due to change in the Windows icon file format.

David Robinow <drobinow@gmail.com> writes:

> Microsoft Visual Studio .NET 2003 fails at:
>
> rc -i../nt -Foobj-spd/i386/emacs.res ../nt/emacs.rc
> ../nt/emacs.rc(1) : error RC2176 : old DIB in icons\emacs.ico; pass it
> through SDKPAINT
>
> This error has been present ever since the new icon was added.  I'd
> forgotten about it since I reverted to the Emacs 22 icon for my daily
> builds.  I don't know a good fix.



[-- Attachment #3: Type: message/rfc822, Size: 2862 bytes --]

From: Jason Rumney <jasonr@gnu.org>
To: David Robinow <drobinow@gmail.com>, 2168-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2168: MSVC 2003 Resource Compiler Error
Date: Wed, 04 Feb 2009 18:28:16 +0900
Message-ID: <49895FB0.8030409@gnu.org>

David Robinow wrote:
> I don't know a good fix.
>   

There was a thread about this last May. I've added an entry to 
etc/PROBLEMS describing some workarounds.

bug#2168: MSVC 2003 Resource Compiler Error

[David Robinow]

rc -i../nt -Foobj-spd/i386/emacs.res ../nt/emacs.rc
../nt/emacs.rc(1) : error RC2176 : old DIB in icons\emacs.ico; pass it
through SDKPAINT


This error has been present ever since the new icon was added.
I'd forgotten about it since I reverted to the Emacs 22 icon for my
daily builds.
I don't know a good fix.

bug#2168: marked as done (MSVC 2003 Resource Compiler Error)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]


Your message dated Wed, 04 Feb 2009 18:28:16 +0900
with message-id <49895FB0.8030409@gnu.org>
and subject line Re: bug#2168: MSVC 2003 Resource Compiler Error
has caused the Emacs bug report #2168,
regarding MSVC 2003 Resource Compiler Error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2168: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2168
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3101 bytes --]

From: David Robinow <drobinow@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: MSVC 2003 Resource Compiler Error
Date: Mon, 2 Feb 2009 15:16:45 -0500
Message-ID: <4eb0089f0902021216s4ecf78dfmdfce1cd0ba0d75c1@mail.gmail.com>

rc -i../nt -Foobj-spd/i386/emacs.res ../nt/emacs.rc
../nt/emacs.rc(1) : error RC2176 : old DIB in icons\emacs.ico; pass it
through SDKPAINT


This error has been present ever since the new icon was added.
I'd forgotten about it since I reverted to the Emacs 22 icon for my
daily builds.
I don't know a good fix.



[-- Attachment #3: Type: message/rfc822, Size: 2862 bytes --]

From: Jason Rumney <jasonr@gnu.org>
To: David Robinow <drobinow@gmail.com>, 2168-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2168: MSVC 2003 Resource Compiler Error
Date: Wed, 04 Feb 2009 18:28:16 +0900
Message-ID: <49895FB0.8030409@gnu.org>

David Robinow wrote:
> I don't know a good fix.
>   

There was a thread about this last May. I've added an entry to 
etc/PROBLEMS describing some workarounds.