unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#1469: patch for term.el regression when dealing with long lines under bash
@ 2008-12-26 21:12 Nicholas Maniscalco
  0 siblings, 0 replies; only message in thread
From: Nicholas Maniscalco @ 2008-12-26 21:12 UTC (permalink / raw)
  To: 1469

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

(I sent this to the wrong list earlier.  Resending to, hopefully, the 
right place this time.)

Here's a patch for bug#1469 (term.el regression when dealing with long 
lines under bash).

* term.el (term-emulate-terminal): Decode substring just prior to 
inserting it.  (Bug#1469)

bug#1469 was introduced while fixing bug#1006.  I verified this patch 
against the repro steps in bug#1006 to make sure I haven't made a 
regression.

Can someone please review?  I'd appreciate any feedback.

-- Nicholas

[-- Attachment #2: term.el.patch --]
[-- Type: text/x-patch, Size: 1020 bytes --]

Index: lisp/term.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/term.el,v
retrieving revision 1.107
diff -c -p -r1.107 term.el
*** lisp/term.el	3 Dec 2008 05:48:33 -0000	1.107
--- lisp/term.el	25 Dec 2008 03:45:24 -0000
*************** See `term-prompt-regexp'."
*** 2834,2840 ****
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 			    (insert decoded-substring)
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))
--- 2834,2840 ----
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 				(insert (decode-coding-string (substring str i funny) locale-coding-system))
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-12-26 21:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-26 21:12 bug#1469: patch for term.el regression when dealing with long lines under bash Nicholas Maniscalco

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).