bug#1699: patch for bug#1469 (term.el regression when dealing with long lines under bash)

bug#1699: patch for bug#1469 (term.el regression when dealing with long lines under bash)

[Nicholas Maniscalco]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hello, attached is a patch for bug#1469 (term.el regression when dealing 
with long lines under bash).

* term.el (term-emulate-terminal): Decode substring just prior to 
inserting it.  (Bug#1469)

bug#1469 was introduced while fixing bug#1006.  I verified this patch 
against the repro steps in bug#1006 to make sure I haven't made a 
regression.

Can someone please review?  I'd appreciate any feedback.

-- Nicholas

[-- Attachment #2: term.el.patch --]
[-- Type: text/x-patch, Size: 1020 bytes --]

Index: lisp/term.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/term.el,v
retrieving revision 1.107
diff -c -p -r1.107 term.el
*** lisp/term.el	3 Dec 2008 05:48:33 -0000	1.107
--- lisp/term.el	25 Dec 2008 03:45:24 -0000
*************** See `term-prompt-regexp'."
*** 2834,2840 ****
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 			    (insert decoded-substring)
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))
--- 2834,2840 ----
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 				(insert (decode-coding-string (substring str i funny) locale-coding-system))
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))

bug#1699: marked as done (patch for bug#1469 (term.el regression when dealing with long lines under bash))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]


Your message dated Fri, 26 Dec 2008 22:45:07 +0100
with message-id <f7ccd24b0812261345n12c24368x650a77964c1d475f@mail.gmail.com>
and subject line Re: bug#1699: this is not a bug, please close
has caused the Emacs bug report #1699,
regarding patch for bug#1469 (term.el regression when dealing with long lines under bash)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1699: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1699
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4170 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 419 bytes --]

Hello, attached is a patch for bug#1469 (term.el regression when dealing 
with long lines under bash).

* term.el (term-emulate-terminal): Decode substring just prior to 
inserting it.  (Bug#1469)

bug#1469 was introduced while fixing bug#1006.  I verified this patch 
against the repro steps in bug#1006 to make sure I haven't made a 
regression.

Can someone please review?  I'd appreciate any feedback.

-- Nicholas

[-- Attachment #2.1.2: term.el.patch --]
[-- Type: text/x-patch, Size: 1020 bytes --]

Index: lisp/term.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/term.el,v
retrieving revision 1.107
diff -c -p -r1.107 term.el
*** lisp/term.el	3 Dec 2008 05:48:33 -0000	1.107
--- lisp/term.el	25 Dec 2008 03:45:24 -0000
*************** See `term-prompt-regexp'."
*** 2834,2840 ****
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 			    (insert decoded-substring)
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))
--- 2834,2840 ----
  			  ;; following point if not eob nor insert-mode.
  			  (let ((old-column (current-column))
  				columns pos)
! 				(insert (decode-coding-string (substring str i funny) locale-coding-system))
  			    (setq term-current-column (current-column)
  				  columns (- term-current-column old-column))
  			    (when (not (or (eobp) term-insert-mode))

[-- Attachment #3: Type: message/rfc822, Size: 2591 bytes --]

From: "Juanma Barranquero" <lekktu@gmail.com>
To: 1699-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1699: this is not a bug, please close
Date: Fri, 26 Dec 2008 22:45:07 +0100
Message-ID: <f7ccd24b0812261345n12c24368x650a77964c1d475f@mail.gmail.com>

On Fri, Dec 26, 2008 at 22:18, Nicholas Maniscalco
<nicholas@maniscalco.com> wrote:

> #1699 can be closed.  I misposted to the wrong list.

Done.