* bug#15625: 24.2.50; ebnf2ps generates bad postscript when ebnf-production-name-p is nil
@ 2013-10-15 21:09 Michael Gauland
2013-10-19 2:25 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Michael Gauland @ 2013-10-15 21:09 UTC (permalink / raw)
To: 15625
[-- Attachment #1: Type: text/plain, Size: 3040 bytes --]
When ebnf-production-name-p is nil, ebnf-eps-buffer should generate a
diagram without the production name.
Instead, it generates an invalid file; evince hangs when trying to open
it.
I believe the approporiate fix is to modfiy the BOP function in the
postscript file to drop the prodcution name when it is blank.
The attached dribble file (started with emacs -Q), demonstrates:
1. Loading ebnf2ps
2. Writing a grammar rule.
3. Running ebnf-eps-buffer to generate ebnf--sequence.eps; this file is
valid.
4. Setting ebnf-production-name-p to nil.
5. Running ebnf-eps-buffer again; now ebnf--sequence.eps is invalid.
6. Modifying ebnf2ps.el as described above.
7. Reloading ebfn2ps.el.
8. Running ebnf-eps-buffer yet again; now ebnf--sequence.eps is valid,
and correctly omits the production name from the diagram.
I've also tested this on GNU Emacs 23.4.1 (i486-pc-linux-gnu, GTK+
Version 2.24.10) on Debian stable.
Kind Regards,
Mike Gauland
In GNU Emacs 24.2.50.1 (i386-mingw-nt6.1.7601)
of 2012-08-25 on YAMALOK
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --with-gcc (4.7) --cflags -m32 -O2 -g0 -march=prescott
-mtune=prescott -pipe -IC:/gnuwin32/emacs/include
-IC:/gnuwin32/emacs/lib -IC:/gnuwin32/src -IC:/gnutls/include
-IC:/gnutls/lib -IC:/gnutls/bin -IC:/libxml2/include -IC:/libxml2/lib
-IC:/libxml2/bin --ldflags '
Important settings:
value of $LANG: ENZ
locale-coding-system: cp1252
default enable-multibyte-characters: t
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
<down-mouse-1> <mouse-1> M-x r e p o r t - e m <tab>
<return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Load-path shadows:
None found.
Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822
mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer button faces cus-face files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget
hashtable-print-readable
backquote make-network-process multi-tty emacs)
[-- Attachment #2: ebnf-dribble --]
[-- Type: application/octet-stream, Size: 946 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#15625: 24.2.50; ebnf2ps generates bad postscript when ebnf-production-name-p is nil
2013-10-15 21:09 bug#15625: 24.2.50; ebnf2ps generates bad postscript when ebnf-production-name-p is nil Michael Gauland
@ 2013-10-19 2:25 ` Glenn Morris
2013-10-22 0:48 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2013-10-19 2:25 UTC (permalink / raw)
To: Michael Gauland; +Cc: 15625
That dribble file is rather hard to interpret.
IIUC, you are saying this patch is needed, is that right?
*** lisp/progmodes/ebnf2ps.el 2013-01-01 09:11:05 +0000
--- lisp/progmodes/ebnf2ps.el 2013-10-19 02:23:44 +0000
***************
*** 3912,3918 ****
{/Effect EffectP def
/fP F ForegroundP SetRGB BackgroundP aload pop true BG S
/Effect 0 def
! ( :) S false BG}if
xw yw moveto
hT EL RA
xp yw moveto
--- 3912,3918 ----
{/Effect EffectP def
/fP F ForegroundP SetRGB BackgroundP aload pop true BG S
/Effect 0 def
! ( :) S false BG}{pop}ifelse
xw yw moveto
hT EL RA
xp yw moveto
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#15625: 24.2.50; ebnf2ps generates bad postscript when ebnf-production-name-p is nil
2013-10-19 2:25 ` Glenn Morris
@ 2013-10-22 0:48 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2013-10-22 0:48 UTC (permalink / raw)
To: 15625-done
Version: 24.4
Thanks; patch applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-22 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-15 21:09 bug#15625: 24.2.50; ebnf2ps generates bad postscript when ebnf-production-name-p is nil Michael Gauland
2013-10-19 2:25 ` Glenn Morris
2013-10-22 0:48 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).