* bug#645: 23.0.60; rng-after-change-function error when validation not started
@ 2008-08-03 18:30 Lennart Borgman (gmail)
2008-08-03 19:24 ` Lennart Borgman (gmail)
0 siblings, 1 reply; 4+ messages in thread
From: Lennart Borgman (gmail) @ 2008-08-03 18:30 UTC (permalink / raw)
To: emacs-pretest-bug
The function rng-after-change-function might be called before validation
has started. This results in an error. The patch below corrects this
problem.
Index: rng-valid.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/nxml/rng-valid.el,v
retrieving revision 1.8
diff -u -b -r1.8 rng-valid.el
--- rng-valid.el 3 Jul 2008 12:25:22 -0000 1.8
+++ rng-valid.el 3 Aug 2008 18:27:21 -0000
@@ -304,6 +304,7 @@
(or rng-validate-mode (rng-validate-mode)))
(defun rng-after-change-function (start end pre-change-len)
+ (when rng-validate-up-to-date-end
;; Work around bug in insert-file-contents.
(when (> end (1+ (buffer-size)))
(setq start 1)
@@ -343,7 +344,7 @@
;; Arrange to revalidate
(rng-activate-timers)
;; Need to do this after activating the timer
- (force-mode-line-update))
+ (force-mode-line-update)))
(defun rng-compute-mode-line-string ()
(cond (rng-validate-timer
In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
of 2008-08-01
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#645: 23.0.60; rng-after-change-function error when validation not started
2008-08-03 18:30 bug#645: 23.0.60; rng-after-change-function error when validation not started Lennart Borgman (gmail)
@ 2008-08-03 19:24 ` Lennart Borgman (gmail)
2011-07-10 0:21 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Lennart Borgman (gmail) @ 2008-08-03 19:24 UTC (permalink / raw)
To: Lennart Borgman (gmail), 645; +Cc: emacs-pretest-bug
Hm. Please do not apply this now. I can't see why it can happen that
rng-validate-up-to-date-end is nil. I will investigate it.
Lennart Borgman (gmail) wrote:
> The function rng-after-change-function might be called before validation
> has started. This results in an error. The patch below corrects this
> problem.
>
> Index: rng-valid.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/nxml/rng-valid.el,v
> retrieving revision 1.8
> diff -u -b -r1.8 rng-valid.el
> --- rng-valid.el 3 Jul 2008 12:25:22 -0000 1.8
> +++ rng-valid.el 3 Aug 2008 18:27:21 -0000
> @@ -304,6 +304,7 @@
> (or rng-validate-mode (rng-validate-mode)))
>
> (defun rng-after-change-function (start end pre-change-len)
> + (when rng-validate-up-to-date-end
> ;; Work around bug in insert-file-contents.
> (when (> end (1+ (buffer-size)))
> (setq start 1)
> @@ -343,7 +344,7 @@
> ;; Arrange to revalidate
> (rng-activate-timers)
> ;; Need to do this after activating the timer
> - (force-mode-line-update))
> + (force-mode-line-update)))
>
> (defun rng-compute-mode-line-string ()
> (cond (rng-validate-timer
>
>
>
> In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
> of 2008-08-01
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#645: 23.0.60; rng-after-change-function error when validation not started
2008-08-03 19:24 ` Lennart Borgman (gmail)
@ 2011-07-10 0:21 ` Glenn Morris
2011-07-10 0:45 ` Lennart Borgman
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2011-07-10 0:21 UTC (permalink / raw)
To: 645-done
Never followed up; closing.
"Lennart Borgman (gmail)" wrote:
> Hm. Please do not apply this now. I can't see why it can happen that
> rng-validate-up-to-date-end is nil. I will investigate it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#645: 23.0.60; rng-after-change-function error when validation not started
2011-07-10 0:21 ` Glenn Morris
@ 2011-07-10 0:45 ` Lennart Borgman
0 siblings, 0 replies; 4+ messages in thread
From: Lennart Borgman @ 2011-07-10 0:45 UTC (permalink / raw)
To: 645, rgm; +Cc: 645-done
That is ok. I do not have time to dive into this. And I think a rework
of some parts of Emacs must be done to fix it.
On Sun, Jul 10, 2011 at 02:21, Glenn Morris <rgm@gnu.org> wrote:
>
> Never followed up; closing.
>
> "Lennart Borgman (gmail)" wrote:
>
>> Hm. Please do not apply this now. I can't see why it can happen that
>> rng-validate-up-to-date-end is nil. I will investigate it.
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-10 0:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-03 18:30 bug#645: 23.0.60; rng-after-change-function error when validation not started Lennart Borgman (gmail)
2008-08-03 19:24 ` Lennart Borgman (gmail)
2011-07-10 0:21 ` Glenn Morris
2011-07-10 0:45 ` Lennart Borgman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).