cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

[Joachim Nilsson]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi,

I have found that the cc-mode Ellemtel indentation has become broken in recent CVS head builds.

It gives:

	printf ("foo %d\n",
	arg);

instead of:

	printf ("foo %d\n",
	        arg);

Either cc-mode has changed or (arglist-cont-nonempty) in Emacs has.  I found that if I remove (arglist-cont-nonempty)
from the definition of ellemtel in lisp/progmodes/cc-styles.el it works again.

Regards
 /Jocke


[-- Attachment #2: joachim_nilsson.vcf --]
[-- Type: text/x-vcard, Size: 167 bytes --]

begin:vcard
fn:Joachim Nilsson
n:Nilsson;Joachim
email;internet:joachim.nilsson@vmlinux.org
x-mozilla-html:TRUE
url:http://vmlinux.org/joachim/
version:2.1
end:vcard

cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

[Joachim Nilsson]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Hi!

The bug still exists on CVS HEAD.  I'm making another plead,
this time including a patch to fix the problem (described in
detail below).  Please note that this fix only affects the
Ellemtel style of cc-mode, so it is quite safe to apply.

--- lisp/progmodes/cc-styles.el 24 Feb 2008 10:08:50 -0000      1.49
+++ lisp/progmodes/cc-styles.el 4 Apr 2008 16:42:09 -0000
@@ -171,8 +171,7 @@
                          (case-label           . +)
                          (access-label         . -)
                          (inclass              . ++)
-                        (inline-open          . 0)
-                        (arglist-cont-nonempty))))
+                         (inline-open          . 0))))
 
     ("linux"
      (c-basic-offset  . 8)

Regards
 /Jocke

-------- Original Message --------

Subject: 	

cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

Date: 	

Wed, 26 Mar 2008 09:05:42 +0100

From: 	

Joachim Nilsson <joachim.nilsson@vmlinux.org>

To: 	

bug-gnu-emacs@gnu.org


Hi,

I have found that the cc-mode Ellemtel indentation has become broken in recent CVS head builds.

It gives:

	printf ("foo %d\n",
	arg);

instead of:

	printf ("foo %d\n",
	        arg);

Either cc-mode has changed or (arglist-cont-nonempty) in Emacs has.  I found that if I remove (arglist-cont-nonempty)
from the definition of ellemtel in lisp/progmodes/cc-styles.el it works again.

Regards
 /Jocke




[-- Attachment #2: joachim_nilsson.vcf --]
[-- Type: text/x-vcard, Size: 167 bytes --]

begin:vcard
fn:Joachim Nilsson
n:Nilsson;Joachim
email;internet:joachim.nilsson@vmlinux.org
x-mozilla-html:TRUE
url:http://vmlinux.org/joachim/
version:2.1
end:vcard

Re: cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

[yoshinori.kawahara]

On Apr 5, 2:47 am, Joachim Nilsson <joachim.nils...@vmlinux.org>
wrote:
> Hi!
>
> The bug still exists on CVS HEAD.  I'm making another plead,
> this time including a patch to fix the problem (described in
> detail below).  Please note that this fix only affects the
> Ellemtel style of cc-mode, so it is quite safe to apply.

I use the ellemtel style too, I added the following to my .emacs file
to restore emacs 21 behaviour.

(defun my-c-mode-common-hook ()
  ;; fix up alignment, got broken in emacs22
  (c-set-offset 'arglist-cont-nonempty '(c-lineup-gcc-asm-reg c-lineup-
arglist)))
(add-hook 'c-mode-common-hook 'my-c-mode-common-hook)

bug#113: marked as done (cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]


Your message dated Thu, 31 Jul 2008 10:02:30 -0400
with message-id <87ljzi179l.fsf@stupidchicken.com>
and subject line Re: For 23.1 release ... please.
has caused the Emacs bug report #113,
regarding cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
113: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=113
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7092 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1455 bytes --]

Hi!

The bug still exists on CVS HEAD.  I'm making another plead,
this time including a patch to fix the problem (described in
detail below).  Please note that this fix only affects the
Ellemtel style of cc-mode, so it is quite safe to apply.

--- lisp/progmodes/cc-styles.el 24 Feb 2008 10:08:50 -0000      1.49
+++ lisp/progmodes/cc-styles.el 4 Apr 2008 16:42:09 -0000
@@ -171,8 +171,7 @@
                          (case-label           . +)
                          (access-label         . -)
                          (inclass              . ++)
-                        (inline-open          . 0)
-                        (arglist-cont-nonempty))))
+                         (inline-open          . 0))))
 
     ("linux"
      (c-basic-offset  . 8)

Regards
 /Jocke

-------- Original Message --------

Subject: 	

cc-mode in Emacs CVS head: Ellemtel indent broken or (arglist-cont-nonempty) recently changed?

Date: 	

Wed, 26 Mar 2008 09:05:42 +0100

From: 	

Joachim Nilsson <joachim.nilsson@vmlinux.org>

To: 	

bug-gnu-emacs@gnu.org


Hi,

I have found that the cc-mode Ellemtel indentation has become broken in recent CVS head builds.

It gives:

	printf ("foo %d\n",
	arg);

instead of:

	printf ("foo %d\n",
	        arg);

Either cc-mode has changed or (arglist-cont-nonempty) in Emacs has.  I found that if I remove (arglist-cont-nonempty)
from the definition of ellemtel in lisp/progmodes/cc-styles.el it works again.

Regards
 /Jocke




[-- Attachment #2.1.2: joachim_nilsson.vcf --]
[-- Type: text/x-vcard, Size: 167 bytes --]

begin:vcard
fn:Joachim Nilsson
n:Nilsson;Joachim
email;internet:joachim.nilsson@vmlinux.org
x-mozilla-html:TRUE
url:http://vmlinux.org/joachim/
version:2.1
end:vcard


[-- Attachment #3: Type: message/rfc822, Size: 1580 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Joachim Nilsson <joachim.nilsson@vmlinux.org>
Cc: emacs-devel@gnu.org, 113-done@emacsbugs.donarmstrong.com
Subject: Re: For 23.1 release ... please.
Date: Thu, 31 Jul 2008 10:02:30 -0400
Message-ID: <87ljzi179l.fsf@stupidchicken.com>

Joachim Nilsson <joachim.nilsson@vmlinux.org> writes:

> PING?
>
> This patch, now with a ChangeLog entry, could be quite useful to get
> into the release. 

Checked in.  Thanks.