* bug#24932: [PATCH] Update module function signature
@ 2016-11-13 2:06 Syohei YOSHIDA
2016-11-13 21:02 ` Daniel Colascione
2016-11-28 15:51 ` Paul Eggert
0 siblings, 2 replies; 4+ messages in thread
From: Syohei YOSHIDA @ 2016-11-13 2:06 UTC (permalink / raw)
To: 24932; +Cc: Syohei YOSHIDA
Second argument of module function is ptrdiff_t, not int.
This fixes a compile warning.
---
modules/modhelp.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/modhelp.py b/modules/modhelp.py
index 5d8f89b..445cb3b 100755
--- a/modules/modhelp.py
+++ b/modules/modhelp.py
@@ -154,7 +154,7 @@ def main():
int plugin_is_GPL_compatible;
static emacs_value
-${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data)
+${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void *data)
{
return env->intern (env, "t");
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#24932: [PATCH] Update module function signature
2016-11-13 2:06 bug#24932: [PATCH] Update module function signature Syohei YOSHIDA
@ 2016-11-13 21:02 ` Daniel Colascione
2016-11-13 21:05 ` Daniel Colascione
2016-11-28 15:51 ` Paul Eggert
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Colascione @ 2016-11-13 21:02 UTC (permalink / raw)
To: Syohei YOSHIDA, 24932
On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote:
> Second argument of module function is ptrdiff_t, not int.
> This fixes a compile warning.
That's an ABI break. We should find another way to fix the warning or
add a new function.
> ---
> modules/modhelp.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/modhelp.py b/modules/modhelp.py
> index 5d8f89b..445cb3b 100755
> --- a/modules/modhelp.py
> +++ b/modules/modhelp.py
> @@ -154,7 +154,7 @@ def main():
> int plugin_is_GPL_compatible;
>
> static emacs_value
> -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data)
> +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void *data)
> {
> return env->intern (env, "t");
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#24932: [PATCH] Update module function signature
2016-11-13 21:02 ` Daniel Colascione
@ 2016-11-13 21:05 ` Daniel Colascione
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Colascione @ 2016-11-13 21:05 UTC (permalink / raw)
To: Syohei YOSHIDA, 24932
On 11/13/2016 01:02 PM, Daniel Colascione wrote:
> On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote:
>> Second argument of module function is ptrdiff_t, not int.
>> This fixes a compile warning.
>
> That's an ABI break. We should find another way to fix the warning or
> add a new function.
Err, never mind. The patch is fine. I just read it too fast.
>
>> ---
>> modules/modhelp.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/modhelp.py b/modules/modhelp.py
>> index 5d8f89b..445cb3b 100755
>> --- a/modules/modhelp.py
>> +++ b/modules/modhelp.py
>> @@ -154,7 +154,7 @@ def main():
>> int plugin_is_GPL_compatible;
>>
>> static emacs_value
>> -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data)
>> +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void
>> *data)
>> {
>> return env->intern (env, "t");
>> }
>>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#24932: [PATCH] Update module function signature
2016-11-13 2:06 bug#24932: [PATCH] Update module function signature Syohei YOSHIDA
2016-11-13 21:02 ` Daniel Colascione
@ 2016-11-28 15:51 ` Paul Eggert
1 sibling, 0 replies; 4+ messages in thread
From: Paul Eggert @ 2016-11-28 15:51 UTC (permalink / raw)
To: Syohei YOSHIDA; +Cc: 24932-done
Thanks for reporting the problem. I installed the fix and am closing the
bug report.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-28 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-13 2:06 bug#24932: [PATCH] Update module function signature Syohei YOSHIDA
2016-11-13 21:02 ` Daniel Colascione
2016-11-13 21:05 ` Daniel Colascione
2016-11-28 15:51 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).