unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#9117: 24.0.50; Document menu keyword `:selected'
@ 2011-07-18 16:23 Drew Adams
  2011-09-11  3:14 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2011-07-18 16:23 UTC (permalink / raw)
  To: 9117

Please document the menu keyword :selected.  Presumably the place for
this would be: `(elisp) Extended Menu Items', along with :visible,
:enable, etc.
 
In particular, document its relation with keywords such as :visible and
:enable - e.g., if not visible then :selected is not evaluated (or
whatever is the truth).
 
For example, I see code such as this in a 3rd-party library, and I
wonder what happens if `ls-lisp-dirs-first' is undefined.  The :visible
sexp here is protected OK (by `ls-lisp-var-p'), but if :selected is
eval'd even when :visible is nil then this would presumably raise an
error.
 
["Ignore Case" dired-sort-menu-toggle-ignore-case :style toggle
    :selected ls-lisp-ignore-case :active t
    :help "Ignore case in alphanumeric sorting"
    ;; supported only by (Emacs 21) ls-lisp library and local dired:
    :visible (ls-lisp-var-p 'ls-lisp-ignore-case)]

["Dirs First" dired-sort-menu-toggle-dirs-first :style toggle
    :selected ls-lisp-dirs-first :active t
    :help "List subdirectories first [last if reversed]"
    ;; supported only by (Emacs 21) ls-lisp library and local dired:
    :visible (ls-lisp-var-p 'ls-lisp-dirs-first)]
 
Anyway, the point is that there seems to be no documentation at all for
:selected, even though it is used in lots of core Lisp code and in
3rd-party code.

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2011-07-11 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.5) --no-opt --cflags
-Ic:/build/include'
 






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#9117: 24.0.50; Document menu keyword `:selected'
  2011-07-18 16:23 bug#9117: 24.0.50; Document menu keyword `:selected' Drew Adams
@ 2011-09-11  3:14 ` Lars Magne Ingebrigtsen
  2016-04-28 11:12   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-09-11  3:14 UTC (permalink / raw)
  To: Drew Adams; +Cc: 9117

"Drew Adams" <drew.adams@oracle.com> writes:

> For example, I see code such as this in a 3rd-party library, and I
> wonder what happens if `ls-lisp-dirs-first' is undefined.  The :visible
> sexp here is protected OK (by `ls-lisp-var-p'), but if :selected is
> eval'd even when :visible is nil then this would presumably raise an
> error.
>
> ["Ignore Case" dired-sort-menu-toggle-ignore-case :style toggle
>     :selected ls-lisp-ignore-case :active t
>     :help "Ignore case in alphanumeric sorting"
>     ;; supported only by (Emacs 21) ls-lisp library and local dired:
>     :visible (ls-lisp-var-p 'ls-lisp-ignore-case)]

:selected is, as far as I can tell, an `easy-menu-define' thing, and is
documented there.  I'm not sure `define-key' supports it at all --
anybody know?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#9117: 24.0.50; Document menu keyword `:selected'
  2011-09-11  3:14 ` Lars Magne Ingebrigtsen
@ 2016-04-28 11:12   ` Lars Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-28 11:12 UTC (permalink / raw)
  To: Drew Adams; +Cc: 9117

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> "Drew Adams" <drew.adams@oracle.com> writes:
>
>> For example, I see code such as this in a 3rd-party library, and I
>> wonder what happens if `ls-lisp-dirs-first' is undefined.  The :visible
>> sexp here is protected OK (by `ls-lisp-var-p'), but if :selected is
>> eval'd even when :visible is nil then this would presumably raise an
>> error.
>>
>> ["Ignore Case" dired-sort-menu-toggle-ignore-case :style toggle
>>     :selected ls-lisp-ignore-case :active t
>>     :help "Ignore case in alphanumeric sorting"
>>     ;; supported only by (Emacs 21) ls-lisp library and local dired:
>>     :visible (ls-lisp-var-p 'ls-lisp-ignore-case)]
>
> :selected is, as far as I can tell, an `easy-menu-define' thing, and is
> documented there.  I'm not sure `define-key' supports it at all --
> anybody know?

Doesn't seem like it.  `easy-menu-define' documents :selected, so I
don't think there's anything to fix here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-28 11:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-18 16:23 bug#9117: 24.0.50; Document menu keyword `:selected' Drew Adams
2011-09-11  3:14 ` Lars Magne Ingebrigtsen
2016-04-28 11:12   ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).