From: Drew Adams <drew.adams@oracle.com>
To: 24721@debbugs.gnu.org
Subject: bug#24721: 25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property
Date: Mon, 17 Oct 2016 15:16:50 -0700 (PDT) [thread overview]
Message-ID: <39fe0ad4-edb6-4364-b611-146e97097695@default> (raw)
When there is multiple advice (from `add-function') of
`isearch-filter-predicate' that has property `isearch-message-prefix',
these prefixes are currently shown left to right in the Isearch prompt,
with the first added being on the left and the last added being on the
right.
I think this is backwards from what a user expects. I've reversed the
order in my own copy, and I think it is more helpful: The first one you
see is the latest applied. Entries are added and removed on the left,
not the right. The most important such prefix is typically the last
one applied, and having it on the left makes it more noticeable (IMO).
If you agree, all that's required is changing, in the
`isearch-message-prefix' code, (concat np prefix) to (concat prefix np).
In GNU Emacs 25.1.1 (x86_64-w64-mingw32)
of 2016-09-17
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --without-dbus --without-compress-install CFLAGS=-static'
next reply other threads:[~2016-10-17 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 22:16 Drew Adams [this message]
2016-10-18 20:23 ` bug#24721: 25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property Juri Linkov
2016-10-18 20:49 ` Drew Adams
2016-10-18 23:01 ` Clément Pit--Claudel
2016-10-18 23:50 ` Drew Adams
2019-11-11 3:33 ` Stefan Kangas
2020-08-20 16:36 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39fe0ad4-edb6-4364-b611-146e97097695@default \
--to=drew.adams@oracle.com \
--cc=24721@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).