From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24721: 25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property Date: Mon, 17 Oct 2016 15:16:50 -0700 (PDT) Message-ID: <39fe0ad4-edb6-4364-b611-146e97097695@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1476742708 32282 195.159.176.226 (17 Oct 2016 22:18:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Oct 2016 22:18:28 +0000 (UTC) To: 24721@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 00:18:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwGEc-000742-1j for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 00:18:18 +0200 Original-Received: from localhost ([::1]:36449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwGEd-00053x-Ey for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Oct 2016 18:18:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwGER-00051s-2v for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:18:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwGEM-0007px-38 for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwGEM-0007pr-0A for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwGEL-0000dy-Pr for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Oct 2016 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24721 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14767426302375 (code B ref -1); Mon, 17 Oct 2016 22:18:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Oct 2016 22:17:10 +0000 Original-Received: from localhost ([127.0.0.1]:37162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwGDW-0000cF-0Z for submit@debbugs.gnu.org; Mon, 17 Oct 2016 18:17:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwGDU-0000c3-4x for submit@debbugs.gnu.org; Mon, 17 Oct 2016 18:17:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwGDO-0006Tw-BY for submit@debbugs.gnu.org; Mon, 17 Oct 2016 18:17:03 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwGDO-0006TU-92 for submit@debbugs.gnu.org; Mon, 17 Oct 2016 18:17:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwGDN-0004q5-7S for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:17:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwGDI-0006MO-5y for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:17:01 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:19863) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwGDH-0006L0-VQ for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2016 18:16:56 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9HMGqoh026099 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 17 Oct 2016 22:16:53 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id u9HMGq6S008408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 17 Oct 2016 22:16:52 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u9HMGp3X026776 for ; Mon, 17 Oct 2016 22:16:51 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124611 Archived-At: When there is multiple advice (from `add-function') of `isearch-filter-predicate' that has property `isearch-message-prefix', these prefixes are currently shown left to right in the Isearch prompt, with the first added being on the left and the last added being on the right. I think this is backwards from what a user expects. I've reversed the order in my own copy, and I think it is more helpful: The first one you see is the latest applied. Entries are added and removed on the left, not the right. The most important such prefix is typically the last one applied, and having it on the left makes it more noticeable (IMO). If you agree, all that's required is changing, in the `isearch-message-prefix' code, (concat np prefix) to (concat prefix np). In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --without-compress-install CFLAGS=3D-static'