From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Glenn Morris <rgm@gnu.org>, 13692@debbugs.gnu.org
Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks
Date: Sat, 30 Jan 2021 04:01:32 +0200 [thread overview]
Message-ID: <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> (raw)
In-Reply-To: <87wnvzf9a1.fsf@gnus.org>
On 27.01.2021 03:39, Lars Ingebrigtsen wrote:
> Dmitry Gutov<dgutov@yandex.ru> writes:
>
>> On 26.01.2021 01:59, Lars Ingebrigtsen wrote:
>>> It's a different problem, but I think this change makes sense.
>> I'm fine with doing it, but someone should look into the buttons
>> beside directory names first (clicking on them stops working if that
>> patch is applied).
> Do you mean the `vc-default-dir-printer' thing?
Huh, never mind. After applying the patch re-compiling both files and
restarting Emacs, the behavior now is as expected. So I pushed the
patch, thank you.
Not sure if we should close this now.
The thing that tripped me up last time was that when
vc-dir-revert-buffer-function is invoked, neither vc-default-dir-printer
nor vc-git-dir-printer are called to re-print the directory entries.
They remain as they were when the VC-Dir buffer was created (unless the
refresh ends up adding some some files in other directories, I suppose).
While we're on the subject of buttons, I think it's odd that mouse-1 and
mouse-2 routinely do the same thing, here and in other cases (e.g. links
in Compilation buffers). But I suppose this is outside of scope for this
discussion.
next prev parent reply other threads:[~2021-01-30 2:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 4:56 bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Glenn Morris
2021-01-20 3:58 ` Lars Ingebrigtsen
2021-01-21 3:08 ` Dmitry Gutov
2021-01-21 14:46 ` Lars Ingebrigtsen
2021-01-23 1:43 ` Dmitry Gutov
2021-01-23 19:02 ` Lars Ingebrigtsen
2021-01-24 2:23 ` Dmitry Gutov
2021-01-25 23:59 ` Lars Ingebrigtsen
2021-01-26 0:36 ` Dmitry Gutov
2021-01-27 1:39 ` Lars Ingebrigtsen
2021-01-30 2:01 ` Dmitry Gutov [this message]
2021-01-30 6:21 ` Lars Ingebrigtsen
2021-01-30 14:05 ` Dmitry Gutov
2021-01-31 7:27 ` Lars Ingebrigtsen
2021-08-23 14:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=13692@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).