From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Sat, 30 Jan 2021 04:01:32 +0200 Message-ID: <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11693"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , 13692@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 30 03:02:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5fb5-0002w8-2I for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jan 2021 03:02:47 +0100 Original-Received: from localhost ([::1]:36540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5fb4-0002Ka-35 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 21:02:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5faQ-0001pm-SC for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 21:02:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5faM-00035X-3u for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 21:02:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5faM-0001OY-1y for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 21:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2021 02:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.16119721065306 (code B ref 13692); Sat, 30 Jan 2021 02:02:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 30 Jan 2021 02:01:46 +0000 Original-Received: from localhost ([127.0.0.1]:53255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5fa5-0001NR-Oz for submit@debbugs.gnu.org; Fri, 29 Jan 2021 21:01:46 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5fa1-0001Mv-Pk for 13692@debbugs.gnu.org; Fri, 29 Jan 2021 21:01:44 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id bl23so15649409ejb.5 for <13692@debbugs.gnu.org>; Fri, 29 Jan 2021 18:01:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bh9rv9Dn9+PyF/LAd2VT15yxaUP+N9UsnZmjVP9doWo=; b=P2kQstsEa5AHdG73JiYWGm5w2qJf0YmAbz8v3Su47jyObXvxHHPkmQdssRxmCDzXaK wMMmsLcBKh/v0DBV/fSWHD3vlgzhPJCZdWEia8dh8hU5KjiastVFW0+2FmoDNidNTHSv z6gJlLaqwgZNCoxZFMAhXDjW+DgSWvu5+djYtA/Ls9/qwVhKUTjfqJYqJhLiO0r85fbu CoML5X93R8lfQ+tXqL4T/0hWyBJRxqasCNPbAvCh4cu7HbRzG449fJzCW44FkZ/LqwQj Rz9HtxpM1ZTWIWIcPremuHNmaJl4n16Nvnk2vG8bXplj9uGlTq2teyDqnGxG0zmsenPx gI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bh9rv9Dn9+PyF/LAd2VT15yxaUP+N9UsnZmjVP9doWo=; b=k2crP5MjFPtHjsowEEys/pz6Vvzi+yVWal7ajMiemQjUrI7Vv0CLMftgEXZm+anx7z qjsAKwVMavt4xUOsdBTIYMWof97Y7Y73xxf8xjNPHTUUL4GbA0luAOOELHuH+4MLgBSH 7V9GbzQXM0QbmQcX5X5E6WTWVGkN2UqTJtdsoJPHpuBWIdE6TkquJtQqQU/Oi7CVZYeY 2fOl/yawYlEASmq1fcqNtKhvk/3PWeFPR777MH6kZKFk+Mddt8w1Xeh2Sz95Hp5U088W BocdgF1Yh6mEVZtpoPJ3hvWnWy2LT4Vy4tChtnoS/z4Y4bzfTqIfraOzWI3dvvCdhpPF CaOQ== X-Gm-Message-State: AOAM531f3A2w5KXlUt5J2fRH1IgI/qtlAamNkDu5181RI6Jyh7xQgUCx 9tgSkUaGf81pFvL9+LG07VCwI98vrlg= X-Google-Smtp-Source: ABdhPJyZSwKAY7VeUz/xlt+sJPD9vHdnfghrMybA+nvkfK1z/cNMxidXjwjI7Y3HKX1aU3txNYNkRw== X-Received: by 2002:a17:906:eb1b:: with SMTP id mb27mr7463667ejb.332.1611972095440; Fri, 29 Jan 2021 18:01:35 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l1sm4490423eje.12.2021.01.29.18.01.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jan 2021 18:01:34 -0800 (PST) In-Reply-To: <87wnvzf9a1.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198890 Archived-At: On 27.01.2021 03:39, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 26.01.2021 01:59, Lars Ingebrigtsen wrote: >>> It's a different problem, but I think this change makes sense. >> I'm fine with doing it, but someone should look into the buttons >> beside directory names first (clicking on them stops working if that >> patch is applied). > Do you mean the `vc-default-dir-printer' thing? Huh, never mind. After applying the patch re-compiling both files and restarting Emacs, the behavior now is as expected. So I pushed the patch, thank you. Not sure if we should close this now. The thing that tripped me up last time was that when vc-dir-revert-buffer-function is invoked, neither vc-default-dir-printer nor vc-git-dir-printer are called to re-print the directory entries. They remain as they were when the VC-Dir buffer was created (unless the refresh ends up adding some some files in other directories, I suppose). While we're on the subject of buttons, I think it's odd that mouse-1 and mouse-2 routinely do the same thing, here and in other cases (e.g. links in Compilation buffers). But I suppose this is outside of scope for this discussion.