unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kai Ma <justksqsf@gmail.com>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 61525@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop
Date: Fri, 18 Aug 2023 21:28:39 +0800	[thread overview]
Message-ID: <37C28861-130C-49CB-B284-82D8AAAA3C3F@gmail.com> (raw)
In-Reply-To: <m1bkf4a3me.fsf@yahoo.es>



> On Aug 18, 2023, at 21:20, Daniel Martín <mardani29@yahoo.es> wrote:
> 
> Daniel Martín <mardani29@yahoo.es> writes:
>> 
>>>> +void ns_make_frame_key_window (struct frame *f)
>>>> +{
>>>> +  [[FRAME_NS_VIEW (f) window] makeKeyWindow];
>>>> +}
>>> 
>>> Is this new call guaranteed to exist and work well on all the
>>> supported OS versions where we have the NS build?  I wouldn't want to
>>> fix this on some systems and break it on others at the same time.
>> 
>> makeKeyWindow is a very old API that should be available on every macOS
>> and GNUstep we support, AFAIK.  I see usages of that API in other parts
>> of the NS build, in things as central as frame creation, and they are
>> not protected by any version or system check.
>> 
> 
> Got a report about some problems closing frames when Emacs runs inside a
> macOS terminal.  So here's a new version of the patch that protects the
> code that makes the other frame the key window, so that it only runs
> when the frame is a GUI frame.
> 
> Kai Ma, could you give it a try and see if everything works well now?
> Thanks.
> 
> <0001-PATCH-NS-Do-not-raise-a-different-frame-when-closing.patch>

Thanks.  Everything works fine now.






  reply	other threads:[~2023-08-18 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  4:26 bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop Kai Ma
2023-02-15 10:54 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 15:41   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 15:49     ` Kai Ma
2023-02-15 17:08     ` Eli Zaretskii
2023-02-15 23:48       ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16  8:10         ` Eli Zaretskii
2023-02-16  8:31           ` Kai Ma
2023-02-16 22:40           ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-17  7:53             ` Eli Zaretskii
2023-08-18 13:20         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-18 13:28           ` Kai Ma [this message]
2023-08-19  3:26           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19  8:28             ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-26  8:06               ` Eli Zaretskii
2023-02-16  1:36       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 21:03         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37C28861-130C-49CB-B284-82D8AAAA3C3F@gmail.com \
    --to=justksqsf@gmail.com \
    --cc=61525@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).