From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kai Ma Newsgroups: gmane.emacs.bugs Subject: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop Date: Fri, 18 Aug 2023 21:28:39 +0800 Message-ID: <37C28861-130C-49CB-B284-82D8AAAA3C3F@gmail.com> References: <835yc2c0vw.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61525@debbugs.gnu.org, Eli Zaretskii To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 18 15:31:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWzZX-0005TV-Au for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Aug 2023 15:31:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWzZ8-0004Bl-7P; Fri, 18 Aug 2023 09:31:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWzYA-0003cc-C5 for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 09:30:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWzYA-00017y-3N for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWzYA-0006Cj-Cz for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2023 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kai Ma Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2023 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61525-submit@debbugs.gnu.org id=B61525.169236534223758 (code B ref 61525); Fri, 18 Aug 2023 13:30:02 +0000 Original-Received: (at 61525) by debbugs.gnu.org; 18 Aug 2023 13:29:02 +0000 Original-Received: from localhost ([127.0.0.1]:46388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzXB-0006B5-FT for submit@debbugs.gnu.org; Fri, 18 Aug 2023 09:29:01 -0400 Original-Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:55550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzXA-0006Ap-7a for 61525@debbugs.gnu.org; Fri, 18 Aug 2023 09:29:00 -0400 Original-Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-6887c3aac15so828362b3a.2 for <61525@debbugs.gnu.org>; Fri, 18 Aug 2023 06:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692365334; x=1692970134; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ny+TPK7B/yTVbVtA55N3E8Sa7RGrhN9dmaVeMbOoijo=; b=h+8EDxea4llDxRrbBaQuwNzjmyoc7ovU+5m8HIwriCpPUumxRZns36mfD1QG4+FRmi YZAoOUsP0jfUXqfDlkX9UmflA4EaGpc+ukqAkigITNSSI3pMRSjDK6hFf7gjrt54wI4o Y3Bn0CvKzhN7H8WXN9pXLqf3U4Vq7il5LTbOrIEXEFXLOQSDn3NCclzJ/yN5GOP7G8e8 jHVRwGvznVJHS6yyNQhJ0OfiU55ttf392knR+PFoVoRt7Zi5PCACUZIHfQ1Ab/R6EIBT c7Rm/R2chNlUtzRJCJDeCBBqcorn/fVJfWK6PsxG+elRaP3MnORlUFj8cpUyLFcPsWJJ Tcew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692365334; x=1692970134; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ny+TPK7B/yTVbVtA55N3E8Sa7RGrhN9dmaVeMbOoijo=; b=WrNbWl3bWAhzTIEwEylgtc+WTggovPoL54hP7I5oXE+wv1bHUo+mnQZ/y8jKlPfCAS prTkbbPtJDetlXC6+Tg0hQWI4HKLLAID2bQyLpHB2cB8694fPNo0NTGDXNQf3++pV//B Bq9+yqBwbEgHh6g6H8ENV+q6yS2DRWVcpX033I9m8ZVgZFdn+IySWqTfnrDoTeHonwXL 7GneKUMQfa8nGab/Kuv7GjGDJINUm5Ya/GaEdQ8za+bj/Vwp2R+AfSUWTtj6k9xT7EBH WM6YShEQ1kYN3sjZmtNjs4LR2oEOaOOkaj5MbR/G9TNiiruoXXxf63kAgOEOknJiyUeK e1sQ== X-Gm-Message-State: AOJu0YxYxRqVqm3ygZcZcgPWocyXFGyb3hiIUIZ2l6Gghf2cbzzOIgSm YHTDJ51VX2573QNlNh+ephU= X-Google-Smtp-Source: AGHT+IG1IXbT5kfY4qIubblEVje9uh9mrUq9qEgS2HXrKeiJju+Xxk9Z75KkZ+YyDMHDkv4cthT7nQ== X-Received: by 2002:a05:6a00:10c8:b0:686:babd:f5c1 with SMTP id d8-20020a056a0010c800b00686babdf5c1mr3077701pfu.25.1692365333806; Fri, 18 Aug 2023 06:28:53 -0700 (PDT) Original-Received: from smtpclient.apple ([2404:c800:922f:e1e:9cf2:fcff:fecc:2ed2]) by smtp.gmail.com with ESMTPSA id n13-20020aa78a4d000000b00682a27905b9sm1590108pfa.13.2023.08.18.06.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Aug 2023 06:28:53 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267762 Archived-At: > On Aug 18, 2023, at 21:20, Daniel Mart=C3=ADn = wrote: >=20 > Daniel Mart=C3=ADn writes: >>=20 >>>> +void ns_make_frame_key_window (struct frame *f) >>>> +{ >>>> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >>>> +} >>>=20 >>> Is this new call guaranteed to exist and work well on all the >>> supported OS versions where we have the NS build? I wouldn't want = to >>> fix this on some systems and break it on others at the same time. >>=20 >> makeKeyWindow is a very old API that should be available on every = macOS >> and GNUstep we support, AFAIK. I see usages of that API in other = parts >> of the NS build, in things as central as frame creation, and they are >> not protected by any version or system check. >>=20 >=20 > Got a report about some problems closing frames when Emacs runs inside = a > macOS terminal. So here's a new version of the patch that protects = the > code that makes the other frame the key window, so that it only runs > when the frame is a GUI frame. >=20 > Kai Ma, could you give it a try and see if everything works well now? > Thanks. >=20 > <0001-PATCH-NS-Do-not-raise-a-different-frame-when-closing.patch> Thanks. Everything works fine now.