From: Paul Eggert <eggert@cs.ucla.edu>
To: Paul Smith <psmith@gnu.org>
Cc: 37484@debbugs.gnu.org
Subject: bug#37484: [PATCH] Support GNU make error messages in compile mode.
Date: Mon, 23 Sep 2019 15:29:05 -0700 [thread overview]
Message-ID: <3660468d-e513-6aea-8d17-9e20035b76da@cs.ucla.edu> (raw)
In-Reply-To: <20190922202817.28319-1-psmith@gnu.org>
Thanks, but when I tried that patch against GNU Emacs master, 'make
check' failed with the diagnostics at the end of this email. Could you
please look into that? Also, please note the following comment in
compile.el, which may be an easier way for you to run the tests:
;; If you make any changes to `compilation-error-regexp-alist-alist',
;; be sure to run the ERT test in test/lisp/progmodes/compile-tests.el.
;; emacs -batch -l compile-tests.el -f ert-run-tests-batch-and-exit
Test compile-test-error-regexps backtrace:
signal(ert-test-failed (((should msg) :form msg :value nil)))
ert-fail(((should msg) :form msg :value nil))
compile--test-error-line(("make: *** [Makefile:20: all] Error 2" 5 n
mapc(compile--test-error-line (("Error on line 3 of t.f: Execution e
#f(compiled-function () #<bytecode 0x5ef685>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name compile-test-error-regexps :documenta
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/compile-te
command-line()
normal-top-level()
Test compile-test-error-regexps condition:
(ert-test-failed
((should msg)
:form msg :value nil))
FAILED 1/2 compile-test-error-regexps (0.062248 sec)
next prev parent reply other threads:[~2019-09-23 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 20:28 bug#37484: [PATCH] Support GNU make error messages in compile mode Paul Smith
2019-09-23 22:29 ` Paul Eggert [this message]
2019-10-05 13:44 ` Paul Smith
2019-10-05 13:59 ` Eli Zaretskii
2019-10-05 19:34 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3660468d-e513-6aea-8d17-9e20035b76da@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=37484@debbugs.gnu.org \
--cc=psmith@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).