From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#37484: [PATCH] Support GNU make error messages in compile mode. Date: Mon, 23 Sep 2019 15:29:05 -0700 Organization: UCLA Computer Science Department Message-ID: <3660468d-e513-6aea-8d17-9e20035b76da@cs.ucla.edu> References: <20190922202817.28319-1-psmith@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142261"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 Cc: 37484@debbugs.gnu.org To: Paul Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 00:30:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCWqS-000am5-QK for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 00:30:12 +0200 Original-Received: from localhost ([::1]:36508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCWqR-0008I7-B6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Sep 2019 18:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCWqK-0008Hy-4D for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 18:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCWqJ-0007HC-1b for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 18:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCWqI-0007H2-U4 for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 18:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCWqI-0008Av-O1 for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2019 18:30:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <20190922202817.28319-1-psmith@gnu.org> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Sep 2019 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37484-submit@debbugs.gnu.org id=B37484.156927775531327 (code B ref 37484); Mon, 23 Sep 2019 22:30:02 +0000 Original-Received: (at 37484) by debbugs.gnu.org; 23 Sep 2019 22:29:15 +0000 Original-Received: from localhost ([127.0.0.1]:37245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCWpX-00089D-13 for submit@debbugs.gnu.org; Mon, 23 Sep 2019 18:29:15 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCWpU-00088j-Nh for 37484@debbugs.gnu.org; Mon, 23 Sep 2019 18:29:13 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 06F2C160203; Mon, 23 Sep 2019 15:29:07 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ldJn_PlvLdH0; Mon, 23 Sep 2019 15:29:06 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3DA08160228; Mon, 23 Sep 2019 15:29:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LJ0e5j6wgI11; Mon, 23 Sep 2019 15:29:06 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 22ED0160203; Mon, 23 Sep 2019 15:29:06 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167051 Archived-At: Thanks, but when I tried that patch against GNU Emacs master, 'make check' failed with the diagnostics at the end of this email. Could you please look into that? Also, please note the following comment in compile.el, which may be an easier way for you to run the tests: ;; If you make any changes to `compilation-error-regexp-alist-alist', ;; be sure to run the ERT test in test/lisp/progmodes/compile-tests.el. ;; emacs -batch -l compile-tests.el -f ert-run-tests-batch-and-exit Test compile-test-error-regexps backtrace: signal(ert-test-failed (((should msg) :form msg :value nil))) ert-fail(((should msg) :form msg :value nil)) compile--test-error-line(("make: *** [Makefile:20: all] Error 2" 5 n mapc(compile--test-error-line (("Error on line 3 of t.f: Execution e #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name compile-test-error-regexps :documenta ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/compile-te command-line() normal-top-level() Test compile-test-error-regexps condition: (ert-test-failed ((should msg) :form msg :value nil)) FAILED 1/2 compile-test-error-regexps (0.062248 sec)