From: Jim Porter <jporterbugs@gmail.com>
To: Liu Hui <liuhui1610@gmail.com>
Cc: 66768-done@debbugs.gnu.org
Subject: bug#66768: 30.0.50; [PATCH] Improve read/append behavior of eshell history command
Date: Fri, 10 Nov 2023 18:03:07 -0800 [thread overview]
Message-ID: <358d06e6-0a07-ffda-1710-400dab7eaecb@gmail.com> (raw)
In-Reply-To: <CAOQTW-P_9G5jiCNUtOw4aFC7eYa0Erv7G98TZ+sNYt4UqK35DA@mail.gmail.com>
Version: 30.1
On 11/7/2023 2:14 AM, Liu Hui wrote:
> Thanks for your comments! I've updated the patch to address all
> concerns.
Everything in your patch looks good to me. I've now merged it as
8b3969006fe (with a small editorial change to a docstring), and added a
few extra regression tests for the history code on top as f2b162f8ee5.
Closing this now. Thanks for helping improve Eshell!
prev parent reply other threads:[~2023-11-11 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 4:15 bug#66768: 30.0.50; [PATCH] Improve read/append behavior of eshell history command Liu Hui
2023-11-03 19:38 ` Jim Porter
2023-11-07 10:14 ` Liu Hui
2023-11-11 2:03 ` Jim Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=358d06e6-0a07-ffda-1710-400dab7eaecb@gmail.com \
--to=jporterbugs@gmail.com \
--cc=66768-done@debbugs.gnu.org \
--cc=liuhui1610@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).