From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#66768: 30.0.50; [PATCH] Improve read/append behavior of eshell history command Date: Fri, 10 Nov 2023 18:03:07 -0800 Message-ID: <358d06e6-0a07-ffda-1710-400dab7eaecb@gmail.com> References: <3d7b6c5e-ee22-91a2-93bd-1fd99d3eb301@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21204"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66768-done@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 03:03:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1dLd-0005Ko-JP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 03:03:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1dLI-0001Sl-4J; Fri, 10 Nov 2023 21:03:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1dLG-0001SI-N9 for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 21:03:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1dLG-0003pE-DJ for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 21:03:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1dLu-0007bg-9Z for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 21:04:02 -0500 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 02:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66768 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 66768@debbugs.gnu.org, jporterbugs@gmail.com, liuhui1610@gmail.com Original-Received: via spool by 66768-done@debbugs.gnu.org id=D66768.169966823829225 (code D ref 66768); Sat, 11 Nov 2023 02:04:02 +0000 Original-Received: (at 66768-done) by debbugs.gnu.org; 11 Nov 2023 02:03:58 +0000 Original-Received: from localhost ([127.0.0.1]:51254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1dLq-0007bJ-8Q for submit@debbugs.gnu.org; Fri, 10 Nov 2023 21:03:58 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:43298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1dLn-0007b3-0u for 66768-done@debbugs.gnu.org; Fri, 10 Nov 2023 21:03:57 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cc3388621cso28565585ad.1 for <66768-done@debbugs.gnu.org>; Fri, 10 Nov 2023 18:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699668189; x=1700272989; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=AerlbqwmixODh4si75YtiqybN1SrR+LFq8+ShpDCXg4=; b=IHVGXspRNNfm+y5d/15Haf29VJXQStNUVFldwHQFx1QAwGk1Iw9bpQH2h6og+k8Iep 1CmcKwnbYBkO+KlpsXAkR0EJi4wLcaVMFGa7f+OEGaEkelTYdPhm0qq6LVJG5/NEwI0s 1P/q8CYm/FaoDYKKxjopzoYit2aNgF/+GMoVYze4fbSNKoP50ji+BaGJa5hRA68U3C2i XIHqAJF2A7xlsoqxzjpRt8TpUo+TxsS9EtQVICzD4ZCmbHMxfuQoa33QTb7PBfgd9ERQ eeHZEFjZfsBfD/th9ZsK6HjKcqaIYY2/zD3+Q5z0yHh0hvn4o0iJgXAzJv4wDzuo5iuV hFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699668189; x=1700272989; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AerlbqwmixODh4si75YtiqybN1SrR+LFq8+ShpDCXg4=; b=ijFIm1euZNH+NfwSHqBmOxUqrAFNtp8FKKxc3AJNRzq0vY6/7mTup/tqjBLCcVHFT0 YVuP6GJ2uGVyiiUB2487TOH5wfOcAOQjnJLIllp9CVzG1nyv4TyD2FLoz226XqjoTAFU wxdyTtgSAON4to+PrRYfcD/kUD0hXKCJ3mbxfx5n3y1AYrpxmQEruHQRXJrlJGWdLxzP ghmjRo1Kd8vU+uGGtWg6gu3OeWYb4LW76P7IAU58jwaMPp0Ja4LEwnPMxs6JtC52Bntz KM888+WqHi8p2X4EPZQR7Br8NzTDkpisJ4Vxq6stOH8YXuOpcslC8Aexk2dnTU46XSSR pekA== X-Gm-Message-State: AOJu0YyfPx7V76sloGL0nO0S/o1x3dmV1z1wcSxLDCAnKRmOl/2anKem irlmVhNyF8aju37tKpFFKrA= X-Google-Smtp-Source: AGHT+IE1ABohNJYfW79QcMUjIEh/02ft5KQsoix+AhMw9MJbGBSYfA/5KSRzvsW+TpLZFbBJiHV/CQ== X-Received: by 2002:a17:903:32cf:b0:1cc:4625:74e2 with SMTP id i15-20020a17090332cf00b001cc462574e2mr6270805plr.24.1699668188705; Fri, 10 Nov 2023 18:03:08 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o21-20020a63fb15000000b005b7e803e672sm372578pgh.5.2023.11.10.18.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 18:03:08 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274126 Archived-At: Version: 30.1 On 11/7/2023 2:14 AM, Liu Hui wrote: > Thanks for your comments! I've updated the patch to address all > concerns. Everything in your patch looks good to me. I've now merged it as 8b3969006fe (with a small editorial change to a docstring), and added a few extra regression tests for the history code on top as f2b162f8ee5. Closing this now. Thanks for helping improve Eshell!