bug#5369: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil

bug#5369: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil

[Michael Heerdegen]

Hello Glenn,

some days ago, you closed my bug report concerning the Byte Compiler of
Gnu Emacs. I have found another compiler bug, and since you seem to be
involved in the last changes of bytecomp.el, I send it to you instead of
opening a new bug report; I hope this is ok; could you please check if
the following can be reproduced with the current version of bytecomp?

Byte compile the following file with emacs -Q:

;; -*- byte-compile-dynamic-docstrings: nil -*-

(defadvice startup-echo-area-message
  (around my-startup-echo-area-message freeze)
  "This is a test advice."
  (setq ad-return-value
	"Welcome to GNU Emacs and happy hacking!"))

Compilation succeeds, but when I load the resulting file, I get an
error:

Load error for /media/sda1/test.elc:
(invalid-read-syntax #)

My compiled file looks like this:

;ELC.\0.\0
;;; Compiled by micha@dragon on Sat Jan  9 22:32:31 2010
;;; from file /media/sdb1/test.el
;;; in Emacs version 23.1.1
;;; with all optimizations.

;;; This file uses opcodes which do not exist in Emacs 18.
(if (and (boundp 'emacs-version)
	 (< (aref emacs-version (1- (length emacs-version))) ?A)
	 (or (and (boundp 'epoch::version) epoch::version)
	     (string-lessp emacs-version "19")))
    (error "`test.el' was compiled for Emacs 19 or later"))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;


(byte-code "\301\302!\204.\0\302\300\303\304N\236A.\301\b!\205.\0\bK)\206.\0\303KM\210\301\207" [origname fboundp ad-Orig-startup-echo-area-message-around-my-startup-echo-area-message startup-echo-area-message ad-advice-info] 4)
(defalias 'startup-echo-area-message #[nil "\301.\302.)\302\207" [ad-return-value nil "Welcome to GNU Emacs and happy hacking!"] 1 #\
("This function is advised.

Permanent around-advice `my-startup-echo-area-message':
This is a test advice." 0 25 (face font-lock-warning-face ad-advice-info startup-echo-area-message) 25 105 (ad-advice-info startup-echo-area-message))])

This was done with Emacs 23.1.1; the problem doesn't appear in my Emacs 22.


Thanks in advance,

Michael.

bug#5369: Bug#5369: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil

[Glenn Morris]

Michael Heerdegen wrote:

> (defalias 'startup-echo-area-message #[nil "\301.\302.)\302\207" [ad-return-value nil "Welcome to GNU Emacs and happy hacking!"] 1 #\
> ("This function is advised.
>
> Permanent around-advice `my-startup-echo-area-message':
> This is a test advice." 0 25 (face font-lock-warning-face ad-advice-info startup-echo-area-message) 25 105 (ad-advice-info startup-echo-area-message))])

This seems to be because ad-make-advised-docstring returns a propertized
doc-string. I don't know how to make it not do that when the output is
to be used for compilation.

bug#5369: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil

[Noam Postavsky]

found 5369 24.3
quit

In 24.4 defadvice no longer supports the `freeze' flag, so this bug is
no longer applicable.