From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 66752@debbugs.gnu.org, tsdh@gnu.org
Subject: bug#66752: 30.0.50; [PATCH] Add support for 'thing-at-point' to 'bug-reference-mode'
Date: Sat, 4 Nov 2023 23:21:59 -0700 [thread overview]
Message-ID: <33dea8de-1260-6eb9-3f71-5e1dd56a2edf@gmail.com> (raw)
In-Reply-To: <83fs1k4vgt.fsf@gnu.org>
On 11/4/2023 10:31 PM, Eli Zaretskii wrote:
>> Date: Sat, 4 Nov 2023 13:07:38 -0700
>> Cc: 66752@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>> From: Jim Porter <jporterbugs@gmail.com>
>>
>> I don't know if that's a case we want to support; maybe I'm just being
>> overly cautious. (Or maybe there should be - or already is - some
>> utility function that does this for us.) Eli, do you have any thoughts
>> on this part?
>
> I don't see any problems with this. But I added Stefan in case he has
> an opinion.
Another implementation option might be:
1. When activating 'bug-reference-mode', only add
'bug-reference--url-at-point' to 'thing-at-point-provider-alist' if it's
not already there,
2. Do nothing when deactivating 'bug-reference-mode', and
3. Inside bug-reference--url-at-point' always return nil if
'bug-reference-mode' is inactive.
Though I suppose this would use 'cl-pushnew' for (1), which might be
inadvisable given the recent discussion on emacs-devel. (Or we could use
'add-to-list', but its docstring says "please do not abuse it in Elisp
code, where you are usually better off using ‘push’ or ‘cl-pushnew’.")
I don't have a very strong opinion on this part, so I'll do whatever
makes everyone happy here.
next prev parent reply other threads:[~2023-11-05 6:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 22:33 bug#66752: 30.0.50; [PATCH] Add support for 'thing-at-point' to 'bug-reference-mode' Jim Porter
2023-11-04 8:12 ` Eli Zaretskii
2023-11-04 19:24 ` Tassilo Horn
2023-11-04 20:07 ` Jim Porter
2023-11-05 5:31 ` Eli Zaretskii
2023-11-05 6:21 ` Jim Porter [this message]
2023-11-05 14:19 ` Stefan Kangas
2023-11-05 23:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 4:55 ` Jim Porter
2023-11-12 5:41 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33dea8de-1260-6eb9-3f71-5e1dd56a2edf@gmail.com \
--to=jporterbugs@gmail.com \
--cc=66752@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).