From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#66752: 30.0.50; [PATCH] Add support for 'thing-at-point' to 'bug-reference-mode' Date: Sat, 4 Nov 2023 23:21:59 -0700 Message-ID: <33dea8de-1260-6eb9-3f71-5e1dd56a2edf@gmail.com> References: <87o7g9tj79.fsf@gnu.org> <47a54242-d331-5864-7b2c-f1990034091a@gmail.com> <83fs1k4vgt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66752@debbugs.gnu.org, tsdh@gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 05 07:22:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzWX4-0007Og-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Nov 2023 07:22:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzWWi-0008WE-9q; Sun, 05 Nov 2023 01:22:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzWWg-0008Vg-22 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 01:22:26 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzWWf-0004QV-Nx for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 01:22:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzWXF-0000bE-T7 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 01:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2023 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66752-submit@debbugs.gnu.org id=B66752.16991653652281 (code B ref 66752); Sun, 05 Nov 2023 06:23:01 +0000 Original-Received: (at 66752) by debbugs.gnu.org; 5 Nov 2023 06:22:45 +0000 Original-Received: from localhost ([127.0.0.1]:36033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzWWz-0000ai-3x for submit@debbugs.gnu.org; Sun, 05 Nov 2023 01:22:45 -0500 Original-Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]:47392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzWWx-0000aT-EJ for 66752@debbugs.gnu.org; Sun, 05 Nov 2023 01:22:44 -0500 Original-Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-5a87ac9d245so40979777b3.3 for <66752@debbugs.gnu.org>; Sat, 04 Nov 2023 23:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699165321; x=1699770121; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=nEKKpbFLkeMlYjNlcgQOxpJOVxdEJjwfEytEWAXSAiU=; b=ReyzxbSIaNaYz03pmuCewLUNcToS+f8zx9ZiMvoEkBzTgLfkaYfy3+0GJzIIxw6gPN d2ks387+At+trpiaIAmtfqpyCeScJOnKcz2sVbo0D77foucBafpdi5AitKmNPWJBZs0O deCAPRDLI7QE4lHlqgVAPs62DuTGNtCMud0r80tO2Yt2+e10vvoECY/uqIDRz0MVAsz2 1EQe/dA7TuppEw6mPRa5M0KU4Ci+G2QDvT4D5uaQX6YoWfdE2fDZirB5SuGQfnWFgolD 4nlQR2YUn1Fi6QDh/Z6IZpdygb/EpdfeFNgk2BP+c2BRLwUMy9BiLeKZ1HvoM9vdJE9D 5eGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699165321; x=1699770121; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nEKKpbFLkeMlYjNlcgQOxpJOVxdEJjwfEytEWAXSAiU=; b=bYok791j1KAy38G10bL9MiSvaytkoMarje5NV34ZNnCg1s2hyLgmBTck6PeLZUWw2O JdNjP7eMxH/5A3SqlBWbkYKBD1SsyoFosg+4vR3Z4UdieXIZgQzTwXzbeoNNgUGhUUcR eE1woqG/GneZj+Un1M0BjDlQlJRioYLvDzekRW7hcVhwSphc/meG3lVsfS33KBWppO44 iz9+766/OXEV78/IBIWDJ9XbFZiHvwYeKqFMl6vtB3bGiSFsYevW4/yavVxg+bn1xDbv nQr2zG/oJ1l55K2RW7vP1bzdnZjHFwB/a0QUOOruOBhfQMatxoMKTtYqKySd+C+oo4z/ TGHw== X-Gm-Message-State: AOJu0YyrED1552P3lr0tXaHyysHgWLhkRrRzi9D16sfg6AzehLGbRIeO tHrLYxqzExzz1bR/2lt0ohw= X-Google-Smtp-Source: AGHT+IEgeDIMTQmI/BTGQcLD8UJUuL8+cpFCB4HEw26aBUDDjpR0jpwJ1ipOP5svLw+cjw4e9jXrEA== X-Received: by 2002:a0d:dd02:0:b0:5ad:47ba:fa43 with SMTP id g2-20020a0ddd02000000b005ad47bafa43mr8140322ywe.35.1699165321202; Sat, 04 Nov 2023 23:22:01 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h4-20020a170902eec400b001cc40912649sm3723930plb.304.2023.11.04.23.22.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 23:22:00 -0700 (PDT) Content-Language: en-US In-Reply-To: <83fs1k4vgt.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273806 Archived-At: On 11/4/2023 10:31 PM, Eli Zaretskii wrote: >> Date: Sat, 4 Nov 2023 13:07:38 -0700 >> Cc: 66752@debbugs.gnu.org, Eli Zaretskii >> From: Jim Porter >> >> I don't know if that's a case we want to support; maybe I'm just being >> overly cautious. (Or maybe there should be - or already is - some >> utility function that does this for us.) Eli, do you have any thoughts >> on this part? > > I don't see any problems with this. But I added Stefan in case he has > an opinion. Another implementation option might be: 1. When activating 'bug-reference-mode', only add 'bug-reference--url-at-point' to 'thing-at-point-provider-alist' if it's not already there, 2. Do nothing when deactivating 'bug-reference-mode', and 3. Inside bug-reference--url-at-point' always return nil if 'bug-reference-mode' is inactive. Though I suppose this would use 'cl-pushnew' for (1), which might be inadvisable given the recent discussion on emacs-devel. (Or we could use 'add-to-list', but its docstring says "please do not abuse it in Elisp code, where you are usually better off using ‘push’ or ‘cl-pushnew’.") I don't have a very strong opinion on this part, so I'll do whatever makes everyone happy here.