bug#20630: 25.0.50; Filesets are not saved to .emacs with filesets-save-config

bug#20630: 25.0.50; Filesets are not saved to .emacs with filesets-save-config

[Mihai Olteanu]

[-- Attachment #1: Type: text/plain, Size: 3631 bytes --]

I'm creating a new fileset using 'M-x fileset-add-buffer RET name RET'.
The fileset is successfully created. I then use the 'M-x
filesets-save-config' and the message in the minibuffer is 'wrote
c:/users/olteanum/AppData/Roaming/.emacs'. The datetime of the .emacs
file is indeed updated, but the file contents are not modified. I've
tried to save the filesets with the File-Filesets-SaveFilesets command
from the menu. Same behaviour. When I close and reopen emacs, the
filesets are lost.


In GNU Emacs 25.0.50.1 (x86_64-w64-mingw32) of 2015-01-24 on KAEL
Repository revision: 02cbd38ae4e4a1e4d309a1bb27c031e154c53f27 Windowing
system distributor `Microsoft Corp.', version 6.1.7601 Configured using:
`configure --prefix=/z/emacs --host=x86_64-w64-mingw32
--target=x86_64-w64-mingw32 --build=x86_64-w64-mingw32 --with-wide-int
--with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2
--with-gnutls --with-sound=yes --with-file-notification=yes
--without-dbus --without-imagemagick 'CFLAGS=-Ofast -fomit-frame-pointer
-funroll-loops -g0 -pipe' 'LDFLAGS=-static-libgcc -static-libstdc++
-static -s -Wl,-s''

Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS
LIBXML2 ZLIB

Important settings: value of $LANG: ENU locale-coding-system: cp1252

Major mode: Python

Minor modes in effect: diff-auto-refine-mode: t desktop-save-mode: t
global-hi-lock-mode: t hi-lock-mode: t tooltip-mode: t
global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t
menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t
font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t
auto-encryption-mode: t auto-compression-mode: t line-number-mode: t

Recent messages: Loading
c:/Users/olteanum/AppData/Roaming/.emacs.d/filesets-cache.el
(source)...done Can't guess python-indent-offset, using defaults: 4
ascfilter.py has auto save data; consider M-x recover-this-file Wrote
c:/Users/olteanum/AppData/Roaming/.emacs.d/.emacs.desktop.lock Desktop:
1 frame, 3 buffers restored. For information about GNU Emacs and the GNU
system, type C-h C-a.

Load-path shadows: None found.

Features: (shadow sort gnus-util mail-extr emacsbug message dired
format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail derived rfc2047 rfc2045
ietf-drums mm-util mail-prsvr cl mail-utils cl-extra help-fns cl-macs
seq jka-compr info vc-git diff-mode easy-mmode python json comint ring
ansi-color filesets easymenu pcase edmacro kmacro slime-autoloads
desktop frameset cl-loaddefs cl-lib gv package epg-config hi-lock
time-date tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp
files text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

Memory information: ((conses 16 163646 8986) (symbols 56 21499 0) (miscs
48 59 120) (strings 32 26115 5753) (string-bytes 1 733850) (vectors 16
12600) (vector-slots 8 410433 2411) (floats 8 87 48) (intervals 56 278
0) (buffers 976 14))


[-- Attachment #2: Type: text/html, Size: 5404 bytes --]

bug#20630: 25.0.50; Filesets are not saved to .emacs with filesets-save-config

[Wenjamin Petrenko]

[-- Attachment #1: Type: text/plain, Size: 15 bytes --]

Here's a patch.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-bug-20630.patch --]
[-- Type: text/x-diff; name="fix-bug-20630.patch", Size: 1001 bytes --]

From 5d44116430badf1da81827f4c19e0bdd2c4adf43 Mon Sep 17 00:00:00 2001
From: Wenjamin Petrenko <wenjamin.petrenko@yandex.ru>
Date: Sat, 8 Sep 2018 17:27:56 +0300
Subject: [PATCH] Make `filesets-save-config' save filesets added by `filesets-add-buffer'

* lisp/filesets.el (filesets-set-config): Use `customize-set-variable'
so that filesets are saved by `customize-save-customized' in
`filesets-save-config' (Bug#20630).
---
 lisp/filesets.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/filesets.el b/lisp/filesets.el
index 63f7c75b65..c1e6ef10d5 100644
--- a/lisp/filesets.el
+++ b/lisp/filesets.el
@@ -242,8 +242,7 @@ key is supported."
 (defun filesets-set-config (fileset var val)
   "Set-default wrapper function."
   (filesets-reset-fileset fileset)
-  (set-default var val))
-;  (customize-set-variable var val))
+  (customize-set-variable var val))
 ;  (filesets-build-menu))
 
 ;; It seems this is a workaround for the XEmacs issue described in the
-- 
2.17.1

bug#20630: 25.0.50; Filesets are not saved to .emacs with filesets-save-config

[Eli Zaretskii]

> From: Wenjamin Petrenko <wenjamin.petrenko@yandex.ru>
> Envelope-From: wenjamin-petrenko@yandex.ru
> Date: Sat, 08 Sep 2018 18:40:17 +0300
> 
> Here's a patch.

Thanks, installed on the master branch.