unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 48738@debbugs.gnu.org
Subject: bug#48738: [PATCH] Optimized `describe-variable' predicate
Date: Mon, 31 May 2021 07:30:23 +0200	[thread overview]
Message-ID: <302469b0-79fa-1b4e-035e-448c926f85fe@daniel-mendler.de> (raw)
In-Reply-To: <8735u3mq6w.fsf@gnus.org>

On 5/31/21 7:23 AM, Lars Ingebrigtsen wrote:
> Daniel Mendler <mail@daniel-mendler.de> writes:
> 
>> Yes, I am aware of those. As you say, they don't do what we want here.
>> The question is which name convention to use here. I think having a
>> `buffer-local-boundp` makes sense.
> 
> Added now.

Thanks. While we are on it optimizing, does it make sense to make this a
c function? You can probably tell more about the overhead of condition-case?

However I think `buffer-local-boundp` is really only performance
critical in this single predicate in `describe-variable`. I cannot think
of another use case iterating over thousands of symbols and checking for
bound variables. So probably we are good now.





  reply	other threads:[~2021-05-31  5:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  4:27 bug#48738: [PATCH] Optimized `describe-variable' predicate Daniel Mendler
2021-05-31  4:55 ` Lars Ingebrigtsen
2021-05-31  5:00   ` Daniel Mendler
2021-05-31  5:06     ` Lars Ingebrigtsen
2021-05-31  5:13       ` Lars Ingebrigtsen
2021-05-31  5:19         ` Daniel Mendler
2021-05-31  5:23           ` Lars Ingebrigtsen
2021-05-31  5:30             ` Daniel Mendler [this message]
2021-05-31  5:32               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=302469b0-79fa-1b4e-035e-448c926f85fe@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=48738@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).