From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#48738: [PATCH] Optimized `describe-variable' predicate Date: Mon, 31 May 2021 07:30:23 +0200 Message-ID: <302469b0-79fa-1b4e-035e-448c926f85fe@daniel-mendler.de> References: <55a7f6fc-ccad-a8e3-2f51-1cbc1555a4f8@daniel-mendler.de> <87h7ijmrie.fsf@gnus.org> <87bl8rmr03.fsf@gnus.org> <877djfmqow.fsf@gnus.org> <5954146c-7928-6069-4491-282cc27a25d7@daniel-mendler.de> <8735u3mq6w.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48738@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 07:31:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnaWI-0008NQ-8o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 07:31:22 +0200 Original-Received: from localhost ([::1]:60214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnaWG-0006hI-Hd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 01:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnaVy-0006h7-B1 for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnaVy-0005d7-0s for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnaVx-00060T-Qu for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 01:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 05:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48738 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48738-submit@debbugs.gnu.org id=B48738.162243903423055 (code B ref 48738); Mon, 31 May 2021 05:31:01 +0000 Original-Received: (at 48738) by debbugs.gnu.org; 31 May 2021 05:30:34 +0000 Original-Received: from localhost ([127.0.0.1]:60745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaVV-0005zn-WE for submit@debbugs.gnu.org; Mon, 31 May 2021 01:30:34 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:50255 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaVT-0005z7-NL for 48738@debbugs.gnu.org; Mon, 31 May 2021 01:30:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oD+4utMml/Dx38Rlc9etVWEW00Ib4o1SO7drXVyERlg=; b=QKzUD8qOXPi+xY79NvRV3J/olh oAsCxzQ8jXfPWVHSbCEZQbT3FkA3DYVAWKuAT8QpGgt+iCucGN+GYjprwtedvLiBlEZ5uFSyAjsbv U4Cm/Vw7zBlEuhASqql3X2W8uKkdEBRKmxxLnGIcCVnlW3t4/NyHeZr7oeZhClR9dtro=; In-Reply-To: <8735u3mq6w.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207659 Archived-At: On 5/31/21 7:23 AM, Lars Ingebrigtsen wrote: > Daniel Mendler writes: > >> Yes, I am aware of those. As you say, they don't do what we want here. >> The question is which name convention to use here. I think having a >> `buffer-local-boundp` makes sense. > > Added now. Thanks. While we are on it optimizing, does it make sense to make this a c function? You can probably tell more about the overhead of condition-case? However I think `buffer-local-boundp` is really only performance critical in this single predicate in `describe-variable`. I cannot think of another use case iterating over thousands of symbols and checking for bound variables. So probably we are good now.